Repository navigation
Description
Summary
On Server Detail, a quarantined server renders a red ErrorPanel and the calm Security Quarantine banner at the same time, off one payload that says the server is healthy / quarantined. The error panel is usually the unclassified one, so the user is told to file a bug report about a server that is simply waiting for them to approve it.
This is the same defect #1075 fixed for the macOS tray badge, on a surface that PR deliberately did not touch.
Where
frontend/src/views/ServerDetail.vue:1809
const showDiagnosticPanel = computed(() => {
const d = server.value?.diagnostic
if (!d || !d.code) return false
return d.severity === 'warn' || d.severity === 'error'
})No quarantine exemption. And the quarantine banner at :217 is a separate v-if, not part of the v-if / v-else-if chain at :181–:201, so both blocks render together.
Why the payload looks contradictory
mcpproxy still attempts a connection to a quarantined server so the security scanner can export its tool definitions. That attempt fails, leaving an error-severity diagnostic behind — while internal/health/calculator.go short-circuits quarantined servers to level: healthy, admin_state: quarantined, action: approve. Both facts are true in one response; the UI reads only the first.
Real payload from a live install:
{
"name": "everything",
"quarantined": true,
"diagnostic": {
"code": "MCPX_UNKNOWN_UNCLASSIFIED",
"severity": "error",
"user_message": "mcpproxy could not classify this failure. Please file a bug report so we can add a specific code.",
"fix_steps": [{ "type": "link", "label": "Report a bug", "url": ".../issues/new" }]
},
"health": {
"level": "healthy",
"admin_state": "quarantined",
"summary": "Quarantined for review",
"action": "approve"
}
}Reproduce
- Add an MCP server that cannot connect (an unreachable URL is enough) and leave it quarantined.
- Wait for the admission scan to attempt its inspection connect and fail.
- Open Server Detail for it.
Observed: a red error panel — usually "could not classify this failure, please file a bug report" — stacked directly above the "Quarantined for review" banner.
Expected: the quarantine banner alone. Review is the action; the failed inspection-connect is a consequence of quarantine, not an independent fault to report.
Suggested fix
The precedent is already in this file, one block up. SignInPanel (:181) takes precedence over ErrorPanel for health.action === 'login' (MCP-1821) for exactly this reason — a server needing sign-in is a calm state, not a fault. Quarantine is the second such state.
Narrowest change:
const showDiagnosticPanel = computed(() => {
const d = server.value?.diagnostic
if (!d || !d.code) return false
// Quarantine review is an intentional admin state, and its own banner
// below already tells the user what to do. The failed inspection-connect
// that produced this diagnostic is a consequence of quarantine.
if (server.value?.quarantined) return false
return d.severity === 'warn' || d.severity === 'error'
})Worth checking whether the v-else-if="server.last_error" generic alert at :201 needs the same guard, since suppressing the panel lets that branch through.
The tray equivalent is ServerStatus.isBadgeExempt in native/macos/MCPProxy/MCPProxy/API/Models.swift — isOAuthLoginRequired || isQuarantineReview. Keeping the two surfaces on the same rule would be good; admin_state is the cross-surface contract.
Scope note
Unlike the tray, the frontend has no aggregate error badge (grep -rn "errorCount\|unhealthyCount\|issuesCount" frontend/src → nothing), so there is no permanent-red-dot equivalent here. The impact is one misleading panel on one page, not a persistent global alarm.
Tests
frontend/tests/unit/*.spec.ts — note that src/**/__tests__/*.test.ts files exist but are not picked up by the vitest config.
Activity
fix(web-ui): quarantine is not a fault (#1076) + unblock Windows E2E (#…
fix(webui): stop the audit fixes making their own unfounded claims
fix(health): a quarantined server that cannot start is not healthy
fix(webui): stop the calmest diagnostic rendering as the loudest
fix(webui): stop the UI asserting states it was never told (v0.65.0 U…
fix(telemetry): stop four diagnostics instruments measuring themselves (