Repository navigation
fix(tray): slim the menu + represent code_execution by its sub-calls - #1023
Conversation
The status-bar menu had grown long enough to scroll, which is the opposite of a glance, and the glance itself spent a row on an internal primitive. Menu length (3 rows back): - Drop the grey, disabled "N quarantined server(s)" line — Needs Attention already carries that fact, and actionably. - Drop "Report an Issue…" — the tracker is still reachable through the GitHub link in the About panel's credits. - Move "Add Server..." into the Servers submenu as its first item (Cmd+N still matches; performKeyEquivalent recurses into submenus). It stays at the top level only when there are no servers and therefore no submenu to hold it, so adding the first server is never unreachable. code_execution is an internal primitive, not a call the user made. Since its sub-calls became tool_call records of their own (#1016), they show the REAL work — "jira:get_issue ×3" — where the wrapper row said only "code_execution", naming no server and no tool. A SUCCESSFUL wrapper now rows in neither the tray glance nor the shared usage timeline; a FAILED one still does, through rule 3's failure branch, because a script that died before dispatch has no children to speak for it. Kept in lockstep: GlanceSelection.glanceInternalTools (Swift), AppState.countsTowardUsageTimeline (follows the same set), and runtime.glanceInternalTools (Go). usageAdmissionVersion 3 → 4 so snapshots counted under the old rule are rebuilt instead of carried forward. The Web UI activity list still shows code_execution parents — it is the drill-down home for a script — so the parity test now models the glance as the list filter plus the glance's own narrowing rather than equating the two. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Deploying mcpproxy-docs with
|
| Latest commit: |
4af156a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e0259d8a.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-tray-glance-compact.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Cross-model review (opencode/gpt-5.6-sol) returned 2 P2s, both pre-existing trade-offs rather than regressions of this PR: (1) rejected concurrency sheds are glance rows but stay out of the timeline — the deliberate spec-093 contract, open product question since #1016; (2) failed call_tool_* wrappers reaching the glance via SSE — defended in practice by the server-side default filter on poll and the rule-4 request-id collapse, so no double rows render. Documented here rather than changed. |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 32551714183 --repo smart-mcp-proxy/mcpproxy-go
|
Owner feedback on the tray menu (scrolling appeared) and on code_execution's place in the glance.
Menu length
code_execution is an internal primitive
The glance now shows the real upstream calls a script made — not the wrapper row:
code_executionremoved from the glance discovery set (Swift GlanceSelection + AppState live-count mirror + Go usage aggregate, in lockstep). A FAILED code_execution still rows (it has no children to speak for it).usageAdmissionVersionbumped 3→4 so existing snapshots rebuild under the new rule. Parity test rewritten as an independent two-stage oracle; spec 069 usage contract amended. The Web UI activity list intentionally still shows parent rows (drill-down home).Tests: swift build + 467 filtered Swift tests green (incl. 5 new MenuStructureTests), go runtime suite + lint 0 issues.
🤖 Generated with Claude Code