Skip to content

fix(tray): slim the menu + represent code_execution by its sub-calls - #1023

Merged
Dumbris merged 1 commit into
mainfrom
fix/tray-glance-compact
Aug 22, 2026
Merged

Dumbris merged 1 commit into
mainfrom
fix/tray-glance-compact

Conversation

@Dumbris

@Dumbris Dumbris commented Aug 22, 2026

Copy link
Copy Markdown
Member

Owner feedback on the tray menu (scrolling appeared) and on code_execution's place in the glance.

Menu length

  • Removed the grey "N quarantined server(s)" info line (Needs Attention already carries it)
  • Removed "Report an Issue…" (ProjectLinks.issues kept — mirrored in branding + Web UI)
  • "Add Server…" moved into the Servers submenu as its first item (⌘N still works; falls back to top level only when there are zero servers, so the empty-state user can still reach it)
  • New MenuStructureTests pin the contract through the real rebuildMenu()

code_execution is an internal primitive

The glance now shows the real upstream calls a script made — not the wrapper row: code_execution removed from the glance discovery set (Swift GlanceSelection + AppState live-count mirror + Go usage aggregate, in lockstep). A FAILED code_execution still rows (it has no children to speak for it). usageAdmissionVersion bumped 3→4 so existing snapshots rebuild under the new rule. Parity test rewritten as an independent two-stage oracle; spec 069 usage contract amended. The Web UI activity list intentionally still shows parent rows (drill-down home).

Tests: swift build + 467 filtered Swift tests green (incl. 5 new MenuStructureTests), go runtime suite + lint 0 issues.

🤖 Generated with Claude Code

The status-bar menu had grown long enough to scroll, which is the opposite
of a glance, and the glance itself spent a row on an internal primitive.

Menu length (3 rows back):
- Drop the grey, disabled "N quarantined server(s)" line — Needs Attention
  already carries that fact, and actionably.
- Drop "Report an Issue…" — the tracker is still reachable through the
  GitHub link in the About panel's credits.
- Move "Add Server..." into the Servers submenu as its first item (Cmd+N
  still matches; performKeyEquivalent recurses into submenus). It stays at
  the top level only when there are no servers and therefore no submenu to
  hold it, so adding the first server is never unreachable.

code_execution is an internal primitive, not a call the user made. Since
its sub-calls became tool_call records of their own (#1016), they show the
REAL work — "jira:get_issue ×3" — where the wrapper row said only
"code_execution", naming no server and no tool. A SUCCESSFUL wrapper now
rows in neither the tray glance nor the shared usage timeline; a FAILED one
still does, through rule 3's failure branch, because a script that died
before dispatch has no children to speak for it.

Kept in lockstep: GlanceSelection.glanceInternalTools (Swift),
AppState.countsTowardUsageTimeline (follows the same set), and
runtime.glanceInternalTools (Go). usageAdmissionVersion 3 → 4 so snapshots
counted under the old rule are rebuilt instead of carried forward. The Web
UI activity list still shows code_execution parents — it is the drill-down
home for a script — so the parity test now models the glance as the list
filter plus the glance's own narrowing rather than equating the two.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mcpproxy-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4af156a
Status: ✅  Deploy successful!
Preview URL: https://e0259d8a.mcpproxy-docs.pages.dev
Branch Preview URL: https://fix-tray-glance-compact.mcpproxy-docs.pages.dev

View logs

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Dumbris

Dumbris commented Aug 22, 2026

Copy link
Copy Markdown
Member Author

Cross-model review (opencode/gpt-5.6-sol) returned 2 P2s, both pre-existing trade-offs rather than regressions of this PR: (1) rejected concurrency sheds are glance rows but stay out of the timeline — the deliberate spec-093 contract, open product question since #1016; (2) failed call_tool_* wrappers reaching the glance via SSE — defended in practice by the server-side default filter on poll and the rule-4 request-id collapse, so no double rows render. Documented here rather than changed.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Artifacts

Workflow Run: View Run
Branch: fix/tray-glance-compact

Available Artifacts

  • archive-darwin-amd64 (29 MB)
  • archive-darwin-arm64 (26 MB)
  • archive-linux-amd64 (17 MB)
  • archive-linux-arm64 (15 MB)
  • archive-windows-amd64 (29 MB)
  • archive-windows-arm64 (25 MB)
  • frontend-dist-pr (0 MB)
  • installer-dmg-darwin-amd64 (23 MB)
  • installer-dmg-darwin-arm64 (20 MB)

How to Download

Option 1: GitHub Web UI (easiest)

  1. Go to the workflow run page linked above
  2. Scroll to the bottom "Artifacts" section
  3. Click on the artifact you want to download

Option 2: GitHub CLI

gh run download 32551714183 --repo smart-mcp-proxy/mcpproxy-go

Note: Artifacts expire in 14 days.

@Dumbris
Dumbris merged commit 770b58e into main Aug 22, 2026
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants