Repository navigation
fix(tray): mark code_execution_pool_size restart-required (settings parity) - #1056
Merged
Merged
Conversation
…ve catalog PR #1050 marked the field restart-required in the Web UI one minute before PR #1055 landed the widened settings-parity gate; neither branch saw the other, and native-tests.yml is path-filtered to native/**, so main went red on a job that had not run since 08-22. One-line catalog sync; parity now reports 58 settings consistent.
Deploying mcpproxy-docs with
|
| Latest commit: |
e08954b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e98ec898.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-settings-parity-pool-siz.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 32885895938 --repo smart-mcp-proxy/mcpproxy-go
|
Dumbris
added a commit
that referenced
this pull request
Aug 26, 2026
The document read as an open backlog, but #1055 ("fix(tray): close the 16 findings of the macOS tray UX + settings-parity audit", merged 2026-08-25) fixed all 16, with #1056 as a catalogue follow-up. The header's "no version skew, so every finding below is reproducible from source" is no longer true against main. - Header scopes that claim to the time of the walk and carries a status banner. - New §6 Resolution records the two fixes whose obvious implementation is wrong: F1's severity dot is an attributed-title glyph, not a composite image (the status image stays isTemplate and a template image renders monochrome), and F6 added a parity gate rather than just the three missing keys. - Verified on main rather than taken on trust: Menu/TrayIcon.swift is deleted, TokensView is reachable from Views/MainWindow.swift, MCPProxyApp.swift sets isTemplate + accessibilityDescription + toolTip + attributedTitle glyph, and SettingsCatalog.swift carries deep_scan / instructions / code_execution_max_parallel. Note for anyone tracing this later: #1053's body claims to fix these 16 tray findings, but #1053 touches no Swift file — it is the Web UI cluster its own title names. #1055 is the tray PR. The caveat is stated rather than hidden: this pass could not re-walk the live tray, because macOS Accessibility was revoked on the reviewing machine (check_accessibility -> trusted:false), so the resolution is read from the #1055 diff, not from a second walk.
Dumbris
added a commit
that referenced
this pull request
Aug 27, 2026
* docs(qa): macOS tray UX + settings-parity audit Read-only sweep of the running v0.60.0 tray (accessibility-tree menu walk) plus a static comparison of the tray's native surfaces and settings catalogue against the Web UI. Parity matrix (feature surfaces, settings fields, per-server actions) and 16 ranked findings: dead menu-bar health badge, unlabelled status item, silent action failures, unreachable Agent Tokens view, and three settings fields that drifted out of the tray catalogue. * docs(qa): mark the tray audit resolved, and say what was not re-verified The document read as an open backlog, but #1055 ("fix(tray): close the 16 findings of the macOS tray UX + settings-parity audit", merged 2026-08-25) fixed all 16, with #1056 as a catalogue follow-up. The header's "no version skew, so every finding below is reproducible from source" is no longer true against main. - Header scopes that claim to the time of the walk and carries a status banner. - New §6 Resolution records the two fixes whose obvious implementation is wrong: F1's severity dot is an attributed-title glyph, not a composite image (the status image stays isTemplate and a template image renders monochrome), and F6 added a parity gate rather than just the three missing keys. - Verified on main rather than taken on trust: Menu/TrayIcon.swift is deleted, TokensView is reachable from Views/MainWindow.swift, MCPProxyApp.swift sets isTemplate + accessibilityDescription + toolTip + attributedTitle glyph, and SettingsCatalog.swift carries deep_scan / instructions / code_execution_max_parallel. Note for anyone tracing this later: #1053's body claims to fix these 16 tray findings, but #1053 touches no Swift file — it is the Web UI cluster its own title names. #1055 is the tray PR. The caveat is stated rather than hidden: this pass could not re-walk the live tray, because macOS Accessibility was revoked on the reviewing machine (check_accessibility -> trusted:false), so the resolution is read from the #1055 diff, not from a second walk. * docs(qa): correct two §1 claims that were wrong at the time of the walk Verified against v0.60.0 rather than taken on trust: - The tray Settings tab is named "Raw", not "Raw JSON" (native/macos/MCPProxy/MCPProxy/Views/SettingsView.swift:38 at v0.60.0). The §1.2 inventory, the §2 parity matrix and F6's body all said "Raw JSON". - The Web UI had no /usage route at v0.60.0 - the router's path list runs /, /servers, /repositories, /search, /settings, /secrets, /sessions, /tools, /activity, /security, /tokens with no usage or overview entry. Usage was a Dashboard tab; /usage became a route later, in #1044. The parity matrix's "Usage report | ⚠ savings % on Dashboard | ✅ /usage | inconsistent" overstated the Web UI side of that comparison. Also noted in §6 that three §1.1 menu labels have changed since the walk as part of the F9 fix: Open MCPProxy Window, Open Web UI in Browser, Launch at Login. * docs(qa): re-walk the live tray and record that the findings still hold Replaces the "could not re-walk" caveat with the walk itself. macOS Accessibility was granted, so mcpproxy-ui-test works now; the walk reproduces this audit almost verbatim, because the installed tray is still v0.60.0 with "Update 0.61.0 — ready to restart?" sitting in the menu. Reproduced live: F2 (empty status-bar title, no description, no tooltip), F5 (no Agent Tokens entry), F7 (ElevenLabs "Stop" vs cloudflare-graphql "Disable"; and memory showing status Disabled above action Start), F8 (all three quarantined servers offer only Disable/Stop, Restart, View Logs), F11 (research and deploy still offered at 0 tools), F12 (streamable-http beside http and sse), F15 (29 flat entries), F16 (no tool search), and the pre-#1055 menu labels. One drift worth noting: the Clients block now reads "No clients in the last 24h" rather than listing an idle client - the empty state H5 exists to avoid. The consequence for the resolution section: #1055's fixes are real in the diff but remain unverified against a running tray. That needs the pending 0.61.0 restart or the dev bundle-swap, neither of which this pass did - restarting the tray kills the core it manages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge-order collision between #1050 (web restart badge) and #1055 (widened parity gate):
check-settings-parity.pyfails on main withcode_execution_pool_size: restart mismatch web=True native=False, unnoticed because native-tests.yml is path-filtered. One-line native catalog sync + help text; parity green (58 consistent), swift build clean.