Repository navigation
fix(release): stop generating a redundant version stanza in the brew formula - #1078
Merged
Merged
Conversation
…w formula
The tap's `brew style + audit` workflow has failed on EVERY release since
v0.53.0 (2026-08-05) — eleven consecutive — with:
smart-mcp-proxy/mcpproxy/mcpproxy
* Stable: `version 0.62.0` is redundant with version scanned from URL
Every url in the generated formula already embeds the version, so Homebrew
scans it from the URL. Brew turned the redundant explicit stanza into a hard
audit error somewhere between 2026-07-24 (v0.52.1, the last green run) and
2026-08-05, which is exactly where the streak begins.
Installs were never affected: the audit is a lint gate in the tap repo that
runs AFTER the formula is committed and pushed, so it never gated
publication. What it did do is leave the tap permanently red — the condition
under which a real formula regression would go unnoticed.
`version` remains available to the formula's own `test do assert_match
version.to_s` — it is derived from the URL, not absent.
Verified by reproducing the failure locally against the checked-out tap and
re-running the three commands the tap workflow uses:
brew style smart-mcp-proxy/mcpproxy -> no offenses
brew audit --tap smart-mcp-proxy/mcpproxy --cask --online -> exit 0
brew audit --tap smart-mcp-proxy/mcpproxy --formula --online -> exit 0
brew info --json=v2 ... -> version 0.62.0
and by diffing this generator's rendered output against that audited-green
formula byte for byte.
The tap's checked-in v0.62.0 formula is fixed in
smart-mcp-proxy/homebrew-mcpproxy@162cf39, so the current release is clean
too — not just the next one.
Deploying mcpproxy-docs with
|
| Latest commit: |
3313615
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5e7b7a0c.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-homebrew-formula-redunda.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 33194701750 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Homebrew tap's
brew style + auditworkflow has failed on every release since v0.53.0 (2026-08-05) — eleven consecutive, most recently on v0.62.0:Cause
Every
urlin the generated formula already embeds the version, so Homebrew scans it from the URL and rejects the explicitversionstanza as redundant. Brew turned this into a hard audit error somewhere between 2026-07-24 (v0.52.1, the last green run) and 2026-08-05 — exactly where the streak begins. I confirmed the cause is byte-identical across v0.62.0, v0.61.0, v0.60.0 and v0.59.0, so it is one persistent issue, not a series.Impact
Installs were never affected. The audit is a lint gate in the tap repo that runs after the formula is committed and pushed, so it never gated publication — the tap has had correct URLs and sha256s throughout.
What it did do is leave the tap permanently red, which is the condition under which a genuine formula regression would go unnoticed.
Fix
Drop the
versionstanza from the generator, with a comment explaining why it must not come back.versionstays available to the formula's owntest do assert_match version.to_s— it is derived from the URL, not absent.Verification
Reproduced the failure locally by symlinking the checked-out tap into Homebrew's Taps dir (the same thing the tap workflow does), then re-ran the three commands that workflow uses:
brew style smart-mcp-proxy/mcpproxybrew audit --tap … --cask --online mcpproxybrew audit --tap … --formula --online mcpproxybrew info --json=v2 …versionI also diffed this generator's rendered output — heredoc extracted and run through the same
sedsubstitutions with the real v0.62.0 shas — against the formula I audited green: identical.Local Homebrew state was restored afterwards (the tap was not previously installed, and the symlink was removed).
Companion change
The tap's checked-in v0.62.0 formula is already fixed in smart-mcp-proxy/homebrew-mcpproxy@162cf39, so the current release is clean too, not just the next one. This PR stops the generator reintroducing the stanza at v0.63.0.