From 331361501510c512bfffb3447be8da5fba23efe8 Mon Sep 17 00:00:00 2001 From: Algis Dumbris Date: Fri, 28 Aug 2026 20:26:12 +0300 Subject: [PATCH] fix(release): stop generating a redundant `version` stanza in the brew formula MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The tap's `brew style + audit` workflow has failed on EVERY release since v0.53.0 (2026-08-05) — eleven consecutive — with: smart-mcp-proxy/mcpproxy/mcpproxy * Stable: `version 0.62.0` is redundant with version scanned from URL Every url in the generated formula already embeds the version, so Homebrew scans it from the URL. Brew turned the redundant explicit stanza into a hard audit error somewhere between 2026-07-24 (v0.52.1, the last green run) and 2026-08-05, which is exactly where the streak begins. Installs were never affected: the audit is a lint gate in the tap repo that runs AFTER the formula is committed and pushed, so it never gated publication. What it did do is leave the tap permanently red — the condition under which a real formula regression would go unnoticed. `version` remains available to the formula's own `test do assert_match version.to_s` — it is derived from the URL, not absent. Verified by reproducing the failure locally against the checked-out tap and re-running the three commands the tap workflow uses: brew style smart-mcp-proxy/mcpproxy -> no offenses brew audit --tap smart-mcp-proxy/mcpproxy --cask --online -> exit 0 brew audit --tap smart-mcp-proxy/mcpproxy --formula --online -> exit 0 brew info --json=v2 ... -> version 0.62.0 and by diffing this generator's rendered output against that audited-green formula byte for byte. The tap's checked-in v0.62.0 formula is fixed in smart-mcp-proxy/homebrew-mcpproxy@162cf39, so the current release is clean too — not just the next one. --- .github/workflows/release.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d2e577b0d..4814fad57 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -1852,11 +1852,17 @@ jobs: cd tap mkdir -p Formula + # NOTE: deliberately NO `version` stanza. Every url below embeds the + # version, so Homebrew scans it from the URL, and since ~2026-08-05 + # `brew audit --formula --online` FAILS an explicit stanza with + # "Stable: `version X` is redundant with version scanned from URL". + # That kept the tap's audit workflow red on every release from v0.53.0 + # to v0.62.0. `version` is still available to the test block below — + # it is derived, not absent. Do not re-add it. cat > Formula/mcpproxy.rb << 'FORMULA_EOF' class Mcpproxy < Formula desc "Smart MCP Proxy - Intelligent tool discovery and proxying for MCP servers" homepage "https://github.com/smart-mcp-proxy/mcpproxy-go" - version "${VERSION}" license "MIT" on_macos do