Skip to content

fix(deps): bump transitive dompurify to 3.4.14 - #1186

Merged
Dumbris merged 2 commits into
mainfrom
deps/frontend-dompurify
Sep 2, 2026
Merged

Dumbris merged 2 commits into
mainfrom
deps/frontend-dompurify

Conversation

@Dumbris

@Dumbris Dumbris commented Sep 2, 2026

Copy link
Copy Markdown
Member

Advisory

Dependabot alert on frontend/package-lock.json: dompurify — medium — "IN_PLACE hook removal leaves a detached subtree executable" — first patched in 3.4.13.

frontend/ is the Web UI, embedded into the shipped binary via go:embed, and DOMPurify is what sanitises untrusted content. mcpproxy renders text that can originate from third-party MCP servers, so a sanitiser bypass here is reachable by a hostile upstream — treating this as higher-value than a "medium" rating suggests.

Direct vs transitive

dompurify is not a direct dependency of frontend/. It's pulled in transitively by monaco-editor@0.56.0, which hard-pins it to an exact "3.4.8" in its own package.json (npm view monaco-editor@0.56.0 dependencies confirms this). The repo already carries a dompurify entry under package.json's overrides (previously ^3.4.12) precisely because the parent pins an old exact version — so the same instrument (override) is the right, minimal fix rather than trying to bump monaco-editor itself.

Instrument

Bumped the existing override:

   "overrides": {
-    "dompurify": "^3.4.12",
+    "dompurify": "^3.4.13",

Regenerated the lock entry for the single hoisted node_modules/dompurify node only (version/resolved/integrity), hand-verified against npm view dompurify metadata and validated with a clean npm ci — no unrelated pins touched, no npm audit fix --force.

Verified

  • npm ls dompurify --all → single copy, monaco-editor@0.56.0 └─ dompurify@3.4.14 (≥ 3.4.13, no nested vulnerable copy anywhere in the tree)
  • npm audit → the dompurify/monaco-editor moderate findings are gone; only the pre-existing, unrelated brace-expansion high-severity finding remains (already tracked by its own separate override, out of scope for this PR)
  • rm -rf node_modules && npm ci → clean install, lockfile is internally consistent
  • npm run build (vue-tsc && vite build) → succeeds
  • npx vitest run tests/unit → 108 test files / 1175 tests, all passing
  • npx vue-tsc --noEmit → clean, no type errors

Build artifact note

web/frontend/dist/ (the go:embed target) is gitignored except a tracked .gitkeep placeholder — it is rebuilt fresh by make build / CI from frontend/ every time, so there is no stale committed build artifact to regenerate here.

dompurify is pulled in transitively via monaco-editor, which hard-pins
it to an exact "3.4.8". The frontend/ Web UI is embedded in the shipped
binary via go:embed and DOMPurify sanitises content that can originate
from untrusted upstream MCP servers, so a sanitiser bypass here is
reachable by a hostile server.

Bump the existing dompurify override (already used because the parent
pins it) from ^3.4.12 to ^3.4.13, resolving to 3.4.14 — past the fixed
version for the "IN_PLACE hook removal leaves a detached subtree
executable" advisory (first patched in 3.4.13).
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Deploying mcpproxy-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: caca07e
Status: ✅  Deploy successful!
Preview URL: https://f4c3978d.mcpproxy-docs.pages.dev
Branch Preview URL: https://deps-frontend-dompurify.mcpproxy-docs.pages.dev

View logs

frontend/ resolved brace-expansion@5.0.8, which is inside the vulnerable range
of GHSA-rgw5-rvv9-x895 (>= 4.0.0, < 5.0.9) - DoS via unbounded intermediate
arrays. Dependabot raised this advisory against website/package-lock.json but
NOT against frontend/package-lock.json, despite the same vulnerable version
being resolved there and frontend being the Web UI embedded in the shipped
binary via go:embed.

The override already existed at ^5.0.8, so this is a one-character pin bump
plus the re-lock. Verified: the lockfile integrity for 5.0.9 matches the npm
registry's published hash, a clean rm -rf node_modules && npm ci installs from
it, npm run build succeeds, and the 108-file / 1175-test unit suite passes.
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📦 Build Artifacts

Workflow Run: View Run
Branch: deps/frontend-dompurify

Available Artifacts

  • archive-darwin-amd64 (29 MB)
  • archive-darwin-arm64 (26 MB)
  • archive-linux-amd64 (17 MB)
  • archive-linux-arm64 (15 MB)
  • archive-windows-amd64 (29 MB)
  • archive-windows-arm64 (26 MB)
  • frontend-dist-pr (0 MB)
  • installer-dmg-darwin-amd64 (23 MB)
  • installer-dmg-darwin-arm64 (21 MB)

How to Download

Option 1: GitHub Web UI (easiest)

  1. Go to the workflow run page linked above
  2. Scroll to the bottom "Artifacts" section
  3. Click on the artifact you want to download

Option 2: GitHub CLI

gh run download 33631923855 --repo smart-mcp-proxy/mcpproxy-go

Note: Artifacts expire in 14 days.

@Dumbris
Dumbris enabled auto-merge (squash) September 2, 2026 13:00
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Dumbris
Dumbris merged commit e141a27 into main Sep 2, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants