Repository navigation
fix(deps): bump transitive dompurify to 3.4.14 - #1186
Merged
Merged
Conversation
dompurify is pulled in transitively via monaco-editor, which hard-pins it to an exact "3.4.8". The frontend/ Web UI is embedded in the shipped binary via go:embed and DOMPurify sanitises content that can originate from untrusted upstream MCP servers, so a sanitiser bypass here is reachable by a hostile server. Bump the existing dompurify override (already used because the parent pins it) from ^3.4.12 to ^3.4.13, resolving to 3.4.14 — past the fixed version for the "IN_PLACE hook removal leaves a detached subtree executable" advisory (first patched in 3.4.13).
Deploying mcpproxy-docs with
|
| Latest commit: |
caca07e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f4c3978d.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://deps-frontend-dompurify.mcpproxy-docs.pages.dev |
frontend/ resolved brace-expansion@5.0.8, which is inside the vulnerable range of GHSA-rgw5-rvv9-x895 (>= 4.0.0, < 5.0.9) - DoS via unbounded intermediate arrays. Dependabot raised this advisory against website/package-lock.json but NOT against frontend/package-lock.json, despite the same vulnerable version being resolved there and frontend being the Web UI embedded in the shipped binary via go:embed. The override already existed at ^5.0.8, so this is a one-character pin bump plus the re-lock. Verified: the lockfile integrity for 5.0.9 matches the npm registry's published hash, a clean rm -rf node_modules && npm ci installs from it, npm run build succeeds, and the 108-file / 1175-test unit suite passes.
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 33631923855 --repo smart-mcp-proxy/mcpproxy-go
|
Dumbris
enabled auto-merge (squash)
September 2, 2026 13:00
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advisory
Dependabot alert on
frontend/package-lock.json: dompurify — medium — "IN_PLACE hook removal leaves a detached subtree executable" — first patched in 3.4.13.frontend/is the Web UI, embedded into the shipped binary viago:embed, and DOMPurify is what sanitises untrusted content. mcpproxy renders text that can originate from third-party MCP servers, so a sanitiser bypass here is reachable by a hostile upstream — treating this as higher-value than a "medium" rating suggests.Direct vs transitive
dompurifyis not a direct dependency offrontend/. It's pulled in transitively bymonaco-editor@0.56.0, which hard-pins it to an exact"3.4.8"in its ownpackage.json(npm view monaco-editor@0.56.0 dependenciesconfirms this). The repo already carries adompurifyentry underpackage.json'soverrides(previously^3.4.12) precisely because the parent pins an old exact version — so the same instrument (override) is the right, minimal fix rather than trying to bump monaco-editor itself.Instrument
Bumped the existing override:
"overrides": { - "dompurify": "^3.4.12", + "dompurify": "^3.4.13",Regenerated the lock entry for the single hoisted
node_modules/dompurifynode only (version/resolved/integrity), hand-verified againstnpm view dompurifymetadata and validated with a cleannpm ci— no unrelated pins touched, nonpm audit fix --force.Verified
npm ls dompurify --all→ single copy,monaco-editor@0.56.0 └─ dompurify@3.4.14(≥ 3.4.13, no nested vulnerable copy anywhere in the tree)npm audit→ the dompurify/monaco-editor moderate findings are gone; only the pre-existing, unrelatedbrace-expansionhigh-severity finding remains (already tracked by its own separate override, out of scope for this PR)rm -rf node_modules && npm ci→ clean install, lockfile is internally consistentnpm run build(vue-tsc && vite build) → succeedsnpx vitest run tests/unit→ 108 test files / 1175 tests, all passingnpx vue-tsc --noEmit→ clean, no type errorsBuild artifact note
web/frontend/dist/(the go:embed target) is gitignored except a tracked.gitkeepplaceholder — it is rebuilt fresh bymake build/ CI fromfrontend/every time, so there is no stale committed build artifact to regenerate here.