Skip to content

chore(deps): patch website Dependabot advisories - #1187

Merged
Dumbris merged 2 commits into
mainfrom
deps/website-advisories
Sep 2, 2026
Merged

Dumbris merged 2 commits into
mainfrom
deps/website-advisories

Conversation

@Dumbris

@Dumbris Dumbris commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary

Closes the seven open Dependabot alerts against website/package-lock.json (the Docusaurus source for docs.mcpproxy.app, built by Cloudflare Pages). All seven are transitive under @docusaurus/* or docusaurus-plugin-llms; there are no direct website/package.json dependencies among them.

# Package Advisory Fix
1 brace-expansion High — DoS via unbounded intermediate arrays (GHSA-rgw5-rvv9-x895) Fixed. 5.0.8 -> 5.0.9 via the existing overrides["brace-expansion"] entry (repo already forces one version across minimatch@3 and minimatch@9; bumped the pin).
2 fast-uri High — host confusion via backslash authority introducer (GHSA-7p8r-x3mc-p8w7) Fixed. 3.1.4 -> 3.1.7 (>=3.1.5 required). Its only parent, ajv@8.20.0 (under webpack-dev-server), already declares ^3.0.1, so npm update fast-uri re-resolved within the existing range — no override needed, no package.json change beyond the diff below.
3 js-yaml (3.x line) High — quadratic CPU in !!omap resolution (GHSA-5p4m-2wfm-xmqj) Fixed. 3.15.0 -> 3.15.2 (>=3.15.1 required) under gray-matter@4.0.3 (pulled in by docusaurus-plugin-llms), via a nested overrides["gray-matter"]["js-yaml"] entry so only that branch is touched.
4 js-yaml (4.x line) High — same CVE, 4.x line (GHSA-5p4m-2wfm-xmqj) Fixed. 4.3.0 -> 4.3.2 (>=4.3.1 required) everywhere else in the tree (@docusaurus/utils-validation, cosmiconfig, @11ty/gray-matter, @docusaurus/plugin-content-docs, all of which declare ^4.1.0), via a top-level overrides["js-yaml"] entry. Kept separate from the 3.x line above because a single blanket override would have forced gray-matter's 3.x-API consumer onto the incompatible 4.x major.
5 nanoid High — custom generators loop forever when size is 0 (GHSA-2v37-7h3g-55p8) Fixed. 3.3.16 -> 3.3.18. Its only parent, postcss@8.5.24 (under @docusaurus/bundler), declares ^3.3.16, so npm update nanoid re-resolved within range — no override, no package.json change.
6 image-size High — ICNS parser infinite loop (GHSA-w3rx-r6r6-pgpr) Accepted, no fix available. 2.0.2 is the latest published release; the advisory range is <=2.0.2. See reachability assessment below.
7 image-size High — JXL/HEIF parsers infinite loop (GHSA-5p2g-fcmc-qvqq) Accepted, no fix available. Same package/version as #6; same assessment.

image-size reachability assessment

image-size is pulled in solely by @docusaurus/mdx-loader, which calls imageSizeFromFile() from exactly one place: remark/transformImage/index.js, Docusaurus's remark plugin that auto-injects width/height onto <img> tags rendered from local Markdown images.

Tracing that call site:

  • It only runs against images resolved by getLocalImageAbsolutePath() — i.e. files already present in this repo's docs/ or website/static/ trees (@site/..., absolute-under-staticDirs, or path-relative references). Remote (http(s)://) image URLs are explicitly skipped (parseLocalURLPath returns null for them and the function returns early).
  • This is a static-site build step (docusaurus build, invoked from Cloudflare Pages CI). There is no runtime/production code path — image-size never executes against a live request; there is no server here at all, just prebuilt static assets served by Cloudflare Pages.
  • I grepped the whole repo for .icns/.jxl/.heif/.heic files and found none. The vulnerable parsers are never invoked today.

Net: the only way to trigger either bug would be for someone with write access to this repository to commit a malicious ICNS/JXL/HEIF file and reference it from a Markdown doc — which already requires repo write access (i.e., is not a remote or anonymous attack surface), and the worst case is a hung/timed-out CI build, not data exposure or code execution. Risk accepted pending an upstream fix; left unpatched. Will keep an eye on new image-size releases (Dependabot will keep flagging this until one lands).

Build verification

cd website
npm ci          # fresh install from the committed lockfile — 19 high (down from 23), all remaining are image-size/browserslist downstream, none of the other 5 advisories
npm run build   # runs ./prepare-docs.sh (copies ../docs into website/docs) then `docusaurus build` — build's own script sequence, no separate step needed

Both ran clean: [SUCCESS] Generated static files in "build". — 174 docs processed, docusaurus-plugin-llms generated its output files as usual, no new warnings or errors versus a baseline build.

Verification that vulnerable versions are gone

npm ls brace-expansion   -> 5.0.9 (both minimatch@3 and minimatch@9 branches)
npm ls fast-uri          -> 3.1.7
npm ls js-yaml           -> 4.3.2 (docusaurus branches) and 3.15.2 (gray-matter branch)
npm ls nanoid            -> 3.3.18
npm ls image-size        -> 2.0.2 (unchanged, no patch exists — see assessment above)

npm audit dropped from 23 to 19 findings; the remaining 19 are all image-size itself, the @docusaurus/* packages that transitively depend on it through @docusaurus/mdx-loader, docusaurus-plugin-llms (depends on @docusaurus/core), and browserslist (a separate advisory, not one of the seven in scope for this PR).

Test plan

  • npm ci from the committed lockfile succeeds
  • npm run build succeeds (includes prepare-docs.sh)
  • npm ls confirms all 5 patched packages resolve to fixed versions
  • package.json diff is minimal (3 lines in the overrides block)
  • package-lock.json diff touches only the 5 targeted package entries (verified via diff)

Bump brace-expansion, fast-uri, js-yaml (3.x and 4.x lines), and nanoid
to their patched versions via package.json overrides / lockfile
resolution. All four are transitive under @docusaurus/* or
docusaurus-plugin-llms, pulled in by parents whose declared semver
ranges already permit the fix (fast-uri, nanoid) or that mix two
incompatible major lines (js-yaml 3.x under gray-matter vs 4.x
elsewhere), which now get separate nested overrides.

image-size (ICNS/JXL/HEIF infinite-loop advisories) has no patched
release upstream (2.0.2 is latest). It is only invoked by Docusaurus's
markdown image-size transform against files already committed to this
repo's docs/static trees at build time -- never attacker- or
user-supplied input, and no ICNS/JXL/HEIF file exists in the repo.
Risk accepted; left unpatched pending an upstream fix.

Verified with a clean `npm ci` + `npm run build` from website/.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Deploying mcpproxy-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2a58d05
Status: ✅  Deploy successful!
Preview URL: https://60efadc8.mcpproxy-docs.pages.dev
Branch Preview URL: https://deps-website-advisories.mcpproxy-docs.pages.dev

View logs

@Dumbris
Dumbris enabled auto-merge (squash) September 2, 2026 13:00
Two high-severity browserslist alerts (fix >= 4.28.7) landed against
website/package-lock.json while the rest of this branch was in review, so no
PR covered them.

No override needed: every parent already declares a ^4.x range that admits
4.28.7+, so npm update re-resolved in range. The lockfile diff is browserslist
plus its own data-table dependencies (caniuse-lite, electron-to-chromium,
node-releases, update-browserslist-db, baseline-browser-mapping) and nothing
else.

Verified: the lockfile integrity matches the npm registry's published hash for
4.28.8, a clean rm -rf node_modules && npm ci installs from it, and
npm run build succeeds (174 documents processed).
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📦 Build Artifacts

Workflow Run: View Run
Branch: deps/website-advisories

Available Artifacts

  • archive-darwin-amd64 (29 MB)
  • archive-darwin-arm64 (26 MB)
  • archive-linux-amd64 (17 MB)
  • archive-linux-arm64 (15 MB)
  • archive-windows-amd64 (29 MB)
  • archive-windows-arm64 (26 MB)
  • frontend-dist-pr (0 MB)
  • installer-dmg-darwin-amd64 (23 MB)
  • installer-dmg-darwin-arm64 (21 MB)

How to Download

Option 1: GitHub Web UI (easiest)

  1. Go to the workflow run page linked above
  2. Scroll to the bottom "Artifacts" section
  3. Click on the artifact you want to download

Option 2: GitHub CLI

gh run download 33632120579 --repo smart-mcp-proxy/mcpproxy-go

Note: Artifacts expire in 14 days.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Dumbris
Dumbris merged commit 6e68501 into main Sep 2, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants