Repository navigation
chore(deps): bump test-fixture deps + close dependabot coverage gaps - #1188
Merged
Merged
Conversation
…abot alerts Ten Dependabot alerts (5 per fixture) flagged fast-uri and hono transitive deps in tests/echo-rugpull-server and tests/malicious-mcp-server. Both are local-only npm fixtures for the quarantine/TPA scanner test suite: never published, never shipped, bound to localhost, spawned only from test tooling. Real-world exposure is effectively zero; this is alert-noise hygiene, not a security fix. Bump fast-uri 3.1.4 -> 3.1.5 and hono 4.12.32 -> 4.12.34 in both package-lock.json files, keeping the two fixtures on identical versions. Both are transitive deps of @modelcontextprotocol/sdk (hono) and ajv (fast-uri) and stay within their existing semver ranges, so package.json is untouched. Verified both fixtures still work after the bump: MCP initialize/tools-list/ tools-call round-trips succeed over stdio, and a real mcpproxy instance connects to both and indexes their tools (echo-rugpull: 2 tools, malicious: 3 tools).
.github/dependabot.yml covered gomod:/, github-actions:/, npm:/frontend and npm:/website only. It never watched tests/echo-rugpull-server or tests/malicious-mcp-server, which is exactly why ten alerts (5 identical per fixture, for fast-uri and hono) sat unfixed: nothing was ever going to open a PR for them. Add both, grouped, with a low open-pull-requests-limit and a distinct "chore(deps-fixtures)" commit prefix so fixture noise never crowds out real dependency PRs in review. Swept the rest of the repo for manifests the config also missed: - npm: e2e/playwright, e2e/web-ui-sweep — real CI tooling (OAuth E2E, web-ui-sweep gate), not fixtures; added like frontend/website. - npm: bench/tscg — deliberately NOT added. It pins @tscg/core to an exact version for discovery-profiler benchmark reproducibility (spec 083); auto-bumping would silently invalidate published numbers, same rationale as the existing mcp-go ignore rule. Documented inline instead of an ignore-only entry that would never produce a PR anyway (zero-dep shim). - docker: root Dockerfile (the shipped server-edition image) plus the five docker/scanners/* wrappers (cisco, proximity, ramparts, snyk, trivy) that scanner-images.yml builds and pushes to ghcr.io/smart-mcp-proxy/scanner-* — real, shipped, security-relevant base images that had zero Dependabot coverage. cmd/mcpfixture is `FROM scratch` and has nothing to track, so it's documented as excluded rather than given a no-op entry. - go.mod: single module at repo root, already covered.
Deploying mcpproxy-docs with
|
| Latest commit: |
8ef7e89
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0fc2756a.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://deps-test-fixtures-and-cover.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 33632286032 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits, two different kinds of change:
1.
chore(tests): bump hono/fast-uri in fixture lockfiles to clear Dependabot alertsTen open Dependabot alerts (5 identical per fixture) against
tests/echo-rugpull-server/package-lock.jsonandtests/malicious-mcp-server/package-lock.json:Honest risk framing: both fixtures are local-only, never-published, never-shipped test servers for the quarantine/TPA scanner suite (
tests/README.md), spawned as stdio subprocesses and bound to localhost.hono/fast-uriare transitive deps of@modelcontextprotocol/sdk/ajvthat these fixtures don't even import directly. Real-world exposure is close to zero — this is alert-noise hygiene, not a security fix.Bumped
fast-uri3.1.4→3.1.5 andhono4.12.32→4.12.34 in both lockfiles (both stay within their existing semver ranges, sopackage.jsonis untouched), keeping the two fixtures on identical versions.Verification (no automated Go test drives these directories directly — only
tests/test-quarantine.sh, a manual QA script, andspecs/094-filter-diagnostics/quickstart.md):npm installresolves cleanly in both directories at the exact target versions, and a secondnpm installis a no-op (lockfile is self-consistent).initialize→tools/list→tools/call) against bothindex.jsfiles succeeds — verified with a small script that speaks JSON-RPC over stdio.mcpproxybinary (go build -o /tmp/mcpproxy-fixture-check ./cmd/mcpproxy) and ran it against an isolated config (high port, scratch data dir) pointing at both fixtures: both connect and index successfully (echo-rugpull: 2 tools,malicious: 3 tools, confirmed via/api/v1/statusand/api/v1/servers). Did not run./scripts/test-api-e2e.sh(it blanket-pkills mcpproxy processes and would have hit other agents' running instances on this machine — port 8080 was already occupied by another instance).2.
chore(ci): close dependabot coverage gaps across npm/docker manifestsThe real defect:
.github/dependabot.ymlnever watched either test-fixture directory, so Dependabot could never have opened a PR for the alerts above — they could only be found by reading the alert list by hand. Chose option (a): add both directories, grouped, with a lowopen-pull-requests-limit: 3and a distinctchore(deps-fixtures)commit prefix so fixture bumps don't crowd out real dependency PRs in review.Swept the rest of the repo for manifests the config also missed:
e2e/playwright/package.json,e2e/web-ui-sweep/package.jsonbench/tscg/package.json@tscg/core@1.4.3exactly for discovery-profiler benchmark reproducibility (spec 083) — published numbers (e.g. "TSCG (-23.8%)") are only comparable if the shim doesn't drift. Same rationale as the existingmcp-goignore rule. An ignore-only entry would never produce a PR anyway (the shim is zero-dep).Dockerfile(shipped server-edition image) +docker/scanners/{cisco,proximity,ramparts,snyk,trivy}/Dockerfile(built and pushed toghcr.io/smart-mcp-proxy/scanner-*byscanner-images.yml)cmd/mcpfixture/DockerfileFROM scratch, nothing to track.go.mod(single module at repo root)gomod:/entry.Test plan
npm installin both fixture directories resolves at pinned versions, stable across repeat installsmcpproxybinary connects to and indexes both fixtures via an isolated, non-conflicting instance.github/dependabot.ymlparses as valid YAML (14 update entries)git pushpre-push hooks passed (go build, OpenAPI spec check)