Skip to content

chore(deps): bump test-fixture deps + close dependabot coverage gaps - #1188

Merged
Dumbris merged 2 commits into
mainfrom
deps/test-fixtures-and-coverage
Sep 2, 2026
Merged

Dumbris merged 2 commits into
mainfrom
deps/test-fixtures-and-coverage

Conversation

@Dumbris

@Dumbris Dumbris commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary

Two commits, two different kinds of change:

1. chore(tests): bump hono/fast-uri in fixture lockfiles to clear Dependabot alerts

Ten open Dependabot alerts (5 identical per fixture) against tests/echo-rugpull-server/package-lock.json and tests/malicious-mcp-server/package-lock.json:

Severity Package Issue Fix
high fast-uri host confusion via backslash authority 3.1.5
medium hono algorithmic-complexity DoS in language middleware 4.12.34
medium hono ReDoS in CORS middleware 4.12.34
medium hono memo() retains SSR output across requests 4.12.34
low hono proxy helper leaks Connection-listed headers 4.12.34

Honest risk framing: both fixtures are local-only, never-published, never-shipped test servers for the quarantine/TPA scanner suite (tests/README.md), spawned as stdio subprocesses and bound to localhost. hono/fast-uri are transitive deps of @modelcontextprotocol/sdk/ajv that these fixtures don't even import directly. Real-world exposure is close to zero — this is alert-noise hygiene, not a security fix.

Bumped fast-uri 3.1.4→3.1.5 and hono 4.12.32→4.12.34 in both lockfiles (both stay within their existing semver ranges, so package.json is untouched), keeping the two fixtures on identical versions.

Verification (no automated Go test drives these directories directly — only tests/test-quarantine.sh, a manual QA script, and specs/094-filter-diagnostics/quickstart.md):

  • npm install resolves cleanly in both directories at the exact target versions, and a second npm install is a no-op (lockfile is self-consistent).
  • MCP stdio round-trip (initialize → tools/list → tools/call) against both index.js files succeeds — verified with a small script that speaks JSON-RPC over stdio.
  • Built a throwaway mcpproxy binary (go build -o /tmp/mcpproxy-fixture-check ./cmd/mcpproxy) and ran it against an isolated config (high port, scratch data dir) pointing at both fixtures: both connect and index successfully (echo-rugpull: 2 tools, malicious: 3 tools, confirmed via /api/v1/status and /api/v1/servers). Did not run ./scripts/test-api-e2e.sh (it blanket-pkills mcpproxy processes and would have hit other agents' running instances on this machine — port 8080 was already occupied by another instance).
  • No API changes in hono 4.12.34 affect these fixtures.

2. chore(ci): close dependabot coverage gaps across npm/docker manifests

The real defect: .github/dependabot.yml never watched either test-fixture directory, so Dependabot could never have opened a PR for the alerts above — they could only be found by reading the alert list by hand. Chose option (a): add both directories, grouped, with a low open-pull-requests-limit: 3 and a distinct chore(deps-fixtures) commit prefix so fixture bumps don't crowd out real dependency PRs in review.

Swept the rest of the repo for manifests the config also missed:

Manifest Decision
e2e/playwright/package.json, e2e/web-ui-sweep/package.json Added. Real CI tooling (OAuth E2E tests, the web-ui-sweep release gate), not fixtures.
bench/tscg/package.json Deliberately excluded, documented inline. Pins @tscg/core@1.4.3 exactly for discovery-profiler benchmark reproducibility (spec 083) — published numbers (e.g. "TSCG (-23.8%)") are only comparable if the shim doesn't drift. Same rationale as the existing mcp-go ignore rule. An ignore-only entry would never produce a PR anyway (the shim is zero-dep).
Root Dockerfile (shipped server-edition image) + docker/scanners/{cisco,proximity,ramparts,snyk,trivy}/Dockerfile (built and pushed to ghcr.io/smart-mcp-proxy/scanner-* by scanner-images.yml) Added — real, shipped, security-relevant base images with zero prior Dependabot coverage. Arguably higher-value than the fixture bumps in this PR.
cmd/mcpfixture/Dockerfile Excluded, documented inline. FROM scratch, nothing to track.
go.mod (single module at repo root) Already covered by the existing gomod:/ entry.

Test plan

  • npm install in both fixture directories resolves at pinned versions, stable across repeat installs
  • MCP stdio protocol round-trip against both fixture servers (initialize/tools-list/tools-call)
  • Real mcpproxy binary connects to and indexes both fixtures via an isolated, non-conflicting instance
  • .github/dependabot.yml parses as valid YAML (14 update entries)
  • git push pre-push hooks passed (go build, OpenAPI spec check)

…abot alerts

Ten Dependabot alerts (5 per fixture) flagged fast-uri and hono transitive
deps in tests/echo-rugpull-server and tests/malicious-mcp-server. Both are
local-only npm fixtures for the quarantine/TPA scanner test suite: never
published, never shipped, bound to localhost, spawned only from test
tooling. Real-world exposure is effectively zero; this is alert-noise
hygiene, not a security fix.

Bump fast-uri 3.1.4 -> 3.1.5 and hono 4.12.32 -> 4.12.34 in both
package-lock.json files, keeping the two fixtures on identical versions.
Both are transitive deps of @modelcontextprotocol/sdk (hono) and ajv
(fast-uri) and stay within their existing semver ranges, so package.json
is untouched.

Verified both fixtures still work after the bump: MCP initialize/tools-list/
tools-call round-trips succeed over stdio, and a real mcpproxy instance
connects to both and indexes their tools (echo-rugpull: 2 tools,
malicious: 3 tools).
.github/dependabot.yml covered gomod:/, github-actions:/, npm:/frontend and
npm:/website only. It never watched tests/echo-rugpull-server or
tests/malicious-mcp-server, which is exactly why ten alerts (5 identical
per fixture, for fast-uri and hono) sat unfixed: nothing was ever going to
open a PR for them. Add both, grouped, with a low open-pull-requests-limit
and a distinct "chore(deps-fixtures)" commit prefix so fixture noise never
crowds out real dependency PRs in review.

Swept the rest of the repo for manifests the config also missed:
- npm: e2e/playwright, e2e/web-ui-sweep — real CI tooling (OAuth E2E,
  web-ui-sweep gate), not fixtures; added like frontend/website.
- npm: bench/tscg — deliberately NOT added. It pins @tscg/core to an exact
  version for discovery-profiler benchmark reproducibility (spec 083);
  auto-bumping would silently invalidate published numbers, same rationale
  as the existing mcp-go ignore rule. Documented inline instead of an
  ignore-only entry that would never produce a PR anyway (zero-dep shim).
- docker: root Dockerfile (the shipped server-edition image) plus the five
  docker/scanners/* wrappers (cisco, proximity, ramparts, snyk, trivy) that
  scanner-images.yml builds and pushes to ghcr.io/smart-mcp-proxy/scanner-*
  — real, shipped, security-relevant base images that had zero Dependabot
  coverage. cmd/mcpfixture is `FROM scratch` and has nothing to track, so
  it's documented as excluded rather than given a no-op entry.
- go.mod: single module at repo root, already covered.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mcpproxy-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8ef7e89
Status: ✅  Deploy successful!
Preview URL: https://0fc2756a.mcpproxy-docs.pages.dev
Branch Preview URL: https://deps-test-fixtures-and-cover.mcpproxy-docs.pages.dev

View logs

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📦 Build Artifacts

Workflow Run: View Run
Branch: deps/test-fixtures-and-coverage

Available Artifacts

  • archive-darwin-amd64 (29 MB)
  • archive-darwin-arm64 (26 MB)
  • archive-linux-amd64 (17 MB)
  • archive-linux-arm64 (15 MB)
  • archive-windows-amd64 (29 MB)
  • archive-windows-arm64 (26 MB)
  • frontend-dist-pr (0 MB)
  • installer-dmg-darwin-amd64 (23 MB)
  • installer-dmg-darwin-arm64 (21 MB)

How to Download

Option 1: GitHub Web UI (easiest)

  1. Go to the workflow run page linked above
  2. Scroll to the bottom "Artifacts" section
  3. Click on the artifact you want to download

Option 2: GitHub CLI

gh run download 33632286032 --repo smart-mcp-proxy/mcpproxy-go

Note: Artifacts expire in 14 days.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Dumbris
Dumbris merged commit 7fdeb27 into main Sep 2, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants