Repository navigation
chore: remove accidentally committed warmtiktoken binary, guard against repeats - #1199
Merged
Merged
Conversation
…st repeats `warmtiktoken` (43 MB arm64 Mach-O, the build output of `go build ./bench/cmd/warmtiktoken` run from the repo root) landed at the repo root in #1153. Untrack it, ignore it alongside the other root binaries, and add two pre-commit guards so it cannot happen again: - `check-added-large-files` (8 MB cap, above the largest legitimate screenshot/report) - a local `no-native-binaries` hook that rejects Mach-O/ELF/PE files The blob stays in history; purging it needs a history rewrite, which is left as a separate decision. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Deploying mcpproxy-docs with
|
| Latest commit: |
e8b1d1c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4eb69233.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://claude-cleanup-warmtiktoken.mcpproxy-docs.pages.dev |
`test/e2e-config.json` carried an auto-generated 64-hex api_key since #477. It only ever guarded a localhost test instance and scripts/test-api-e2e.sh extracts whatever key the core logs, so the value is irrelevant — but it trips every secret scanner (gitleaks: generic-api-key). Use an obviously synthetic value, matching the sandbox-integration workflow's "qa-sandbox-ci-test". Also ignore `.osgrep/`: `.osgrep/server.json` (local authToken) was committed on the unmerged pull/165 ref. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
Author
Full-history secret scan (gitleaks 8.x, all refs)520 raw findings, all triaged:
No credential for an external service (GitHub, Anthropic, cloud, Slack, Stripe, Cloudflare) appears anywhere in history. |
Dumbris
enabled auto-merge (squash)
September 2, 2026 15:55
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 33651238614 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
warmtiktoken(43 MB arm64 Mach-O — the output ofgo build ./bench/cmd/warmtiktokenrun from the repo root) was committed at the repo root in #1153. This PR:/warmtiktokenand ignores it (plus/mcpproxy-server) alongside the other root binaries in.gitignorecheck-added-large-files(8 MB cap; largest legitimate screenshot/report is ~6.5 MB) to pre-commitno-native-binariespre-commit hook (scripts/check-no-native-binaries.sh) that rejects Mach-O/ELF/PE files outrightBoth new hooks ran on this commit; the script self-test rejects
warmtiktokenand passes text files.Repo audit
warmtiktokenwas the only compiled executable tracked, and the only tracked file > 8 MB..env, key, cert, DB, log or config-with-credentials files are tracked.mcp_agt_,sk-*,ghp_/github_pat_,AKIA,xox*, private-key headers,AIza,X-API-Key/apikey=with real-looking values) grep clean across the tree: every hit is a documented example, a detector fixture, or a test-only key such ase2e-test-api-key-12345.gitleaks gitscan result is noted in a follow-up comment.Not done here
The 43 MB blob remains in history. Removing it needs
git filter-repo+ a force-push ofmainand every open branch, so that is a separate decision.🤖 Generated with Claude Code