Repository navigation
fix(frontend): Dashboard contrast + web-ui-sweep empty-fleet checks - #1358
Merged
Merged
Conversation
…ecks Dashboard's usage-view first-run CTA used opacity-60 on inherited text color instead of the themed base-content token, producing low-contrast text against bg-base-200 in some themes. Switch to text-base-content/60. The web-ui-sweep servers-list and Activity/Usage checks assumed a non-empty fleet; a sweep run without a fixture upstream renders the first-run empty states instead of the KPI tiles and usage tile (#1049/#1216), which made those two checks fail. Anchor on whichever state the instance should show and assert accordingly instead of assuming a populated fleet.
Deploying mcpproxy-docs with
|
| Latest commit: |
98836ea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ebaab6d3.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://claude-goofy-northcutt-9439d.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 35954712672 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opacity-60on inherited (unthemed) text color instead of thetext-base-content/60token, which read as near-invisible in some themes.web-ui-sweepchecks that assumed a non-empty fleet: the servers-list KPI-counter check and the Activity/Usage parity check now correctly branch on the first-run empty state (servers-first-run-empty/dashboard-usage-first-run), which the app intentionally shows instead of KPI tiles / usage charts when no upstream servers are registered (fix(webui): first-run call to action, onboarding path for a fresh setup, and "what needs me" on the landing page #1049/fix(webui): stop the UI asserting states it was never told (v0.65.0 UX audit) #1216), rather than weakening or dropping the assertions.Test plan
cd frontend && npm run build— succeedscd frontend && npx vitest run— 133 files / 1333 tests pass./scripts/run-web-smoke.shagainst a throwaway instance on127.0.0.1:18080(empty fleet, no fixture) — all 3 previously-failing checks now pass (servers list KPI/empty-state check, Activity/Usage parity check, and the visual-a11y contrast sweep covering the Dashboard first-run CTA in both themes)🤖 Generated with Claude Code