Repository navigation
fix(webui): keep manual OAuth sign-in available for recovery and account switching - #1599
Merged
Merged
Conversation
2 of 3 tasks
tomgrin10
force-pushed
the
fix/manual-oauth-signin
branch
from
October 12, 2026 09:14
2127f5c to
a195b50
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
Thank you @tomgrin10 — this is a clean, well-scoped fix and exactly the right layer for it (a shared eligibility helper rather than another What I checked before merging:
I only retitled the PR to the conventional-commit form our title check requires. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1598.
When an OAuth timeout is classified as a reconnect error, the Web UI hides Login. A healthy connection also has no direct account-switching action.
Add Sign in / Sign in again to the card's More actions menu and the detail page's Actions menu. One shared eligibility helper recognizes configured or discovered OAuth upstreams without depending on the suggested health action or background connection state. Disabled, stdio and non-OAuth servers remain excluded. The existing login endpoint and primary health actions are unchanged.
This PR is based directly on
mainand has no dependency on the remote-browser OAuth PR #1597.Testing
npm run buildpasses, including TypeScript checking. The new tests cover menu actions during reconnect/timeouts, connected OAuth servers, logout, discovered OAuth and exclusion of disabled/stdio/non-OAuth servers. The complete repository suite was not rerun for this UI-only change.The two independent PR branches also merge without conflicts; their combined 14 affected frontend tests and production build pass.