Repository navigation
feat(release-gate): blocking surface-state consistency check (Spec 081 T4) - #1655
Merged
Merged
Conversation
…1 T4) New gate entry invariant/surface-consistency (job surface-consistency) replaces the reserved T4 slot. It boots the five-type server matrix, adds quarantined, disabled, unhealthy and live servers, and asserts that the CLI (`upstream list -o json`), MCP `upstream_servers list` and the rendered Web UI agree with the core's /api/v1/servers on enabled, quarantined, connection state, health.level/admin_state/status and tool counts. Three phases: settled, live (disable via REST with the page left open), reload. A divergence that survives the retries fails the gate with a per-field diff. The macOS tray is recorded as not-compared until T3. ## Changes - cmd/release-gate: consistency comparator + `consistency` subcommand - e2e/web-ui-sweep/surface-snapshot.mjs: long-lived Web UI reader - internal/gatereport: blocking invariant/surface-consistency entry - release-qa-gate.yml: surface-consistency job, verdict dependency, dry-run-only seed_consistency_mismatch input - scripts/test-surface-consistency.sh: local runner - docs, specs/081 tasks.md, roadmap ## Testing - comparator tests: agreement, stale CLI level, MCP state, Web UI chip and tool count, missing/extra servers, capture error, seed - workflow audit: job blocking, compares Web UI, seed gated to dispatch - local run (stdio/http/sse/oauth): pass; seeded webui mismatch: fail
Deploying mcpproxy-docs with
|
| Latest commit: |
03ad256
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4aec9552.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://claude-festive-khayyam-d78ae.mcpproxy-docs.pages.dev |
…check Comparator: - connection state stays compared for disabled/quarantined servers: exactly for the CLI, connected-vs-not for MCP - Web UI expectation mirrors ServerCard's no-health branch and the usable=false "Unavailable" fallback - --seed-mismatch refuses fields the surface is not compared on and servers the surface does not show Live command: - CLI child drops every MCPPROXY_* override (MCPPROXY_DATA picked a socket ahead of the gate's TCP endpoint) - every capture runs under the phase deadline; late agreement fails - a timed-out/cancelled Web UI command kills the reader, so a late reply is never read as the next command's answer - fragment written before teardown; teardown bounded to 2 minutes - stderr buffer is synchronized Local script: Bash 3.2 empty-array expansion, and a trap that runs the new `release-gate teardown` so an early failure leaks no processes.
…e local script Round-2 review: teardown bounded Docker calls only (PID loops and pgrep take no context), so it now runs in a goroutine abandoned after its budget — the verdict is already written. The local script's new cleanup trap tore down an instance kept with --keep-core; it now leaves it up and prints the teardown command.
Dumbris
enabled auto-merge (squash)
October 17, 2026 14:18
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 39040097571 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 081 T4 (US5, FR-018). The release gate now blocks a tag when the CLI, MCP or Web UI shows a server state different from what the core reports.
What it does
New blocking gate entry
invariant/surface-consistency, run by a new jobsurface-consistency. It replaces the reserved T4 slot.matrix-invariants.GET /api/v1/servers:mcpproxy upstream list -o json --config …upstream_serversoperation=list(its own storage + manager projection)/ui/servers, read bye2e/web-ui-sweep/surface-snapshot.mjsServerCard.vue's rules.not_compared(T3)It runs in three phases: settled, live (a server is disabled through REST while the page stays open, which tests the SSE/poll update path) and reload. Each phase retries until the surfaces converge. An attempt counts only if the core state did not change while the surfaces were being read. A divergence that remains after the retries fails the gate with a per-field diff, for example
webui gate-cons-quarantined webui.chip_class: core=badge-secondary webui=badge-success.Negative path:
--seed-mismatch surface:server:field=value, or the dry-run-onlyseed_consistency_mismatchworkflow_dispatch input. A tag'sworkflow_callnever reads it, and an audit test enforces that.Local:
./scripts/test-surface-consistency.shruns next toscripts/test-api-e2e.sh.No new dependencies. The reader reuses the sweep's locked
@playwright/test.Review
Cross-reviewed with opencode
github-copilot/gpt-6.1-sol(zcode login was down at round 1): round 1 → 10 findings, all fixed in 54adbf1; round 2 → 9/10 confirmed fixed + 1 new, both fixed in 03ad256; round 3 → NO NEW FINDINGS.Testing
needslist, and only reads the seed on dispatch.webui:gate-cons-quarantined:webui.chip_class=badge-success): fails in every phase with the diff above.--build-tags server): 0 issues.Related #819 #1030