Skip to content

docs(server): reattach recordToolCallAt doc comment #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dumbris merged 2 commits into from
Oct 20, 2026
Merged

docs(server): reattach recordToolCallAt doc comment #1690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
605dbe1
docs(server): reattach recordToolCallAt doc comment
Dumbris Oct 20, 2026
3ec6be8
Merge remote-tracking branch 'origin/main' into HEAD
Dumbris Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/server/mcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4140,8 +4140,6 @@ func (p *MCPProxyServer) toolCallIncarnation(serverName string) int64 {
return 0
}

// recordToolCallAt records a call's history only while its server still has
// the incarnation the call started on (Spec 116 FR-014c).
// recordOutputBlocked is the bookkeeping a dispatch owes a call whose result
// an output policy (Spec 054 block mode) refused to hand over: the upstream
// ran, so the tool-call history gets the attempt, with the block message in
Expand All @@ -4160,6 +4158,8 @@ func (p *MCPProxyServer) recordOutputBlocked(ctx context.Context, rec *storage.T
return msg
}

// recordToolCallAt records a call's history only while its server still has
// the incarnation the call started on (Spec 116 FR-014c).
func (p *MCPProxyServer) recordToolCallAt(rec *storage.ToolCallRecord, inc int64) error {
written, err := p.storage.RecordToolCallIfIncarnation(rec, inc)
if err == nil && !written {
Expand Down
Loading