Repository navigation
Conversation
Spec approved by OpenCode Sol 6.1 at review round 3; plan under review.
…Docker-default deviation recorded)
Deploying mcpproxy-docs with
|
| Latest commit: |
0740964
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4375681d.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://claude-spec-day-two-activati.mcpproxy-docs.pages.dev |
…prompt blocks, quickstart correlation)
…(Sol plan review r5)
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 40331489668 --repo smart-mcp-proxy/mcpproxy-go
|
…aude/spec-day-two-activation-1fad2a # Conflicts: # ROADMAP.md
…ctivation-1fad2a # Conflicts: # ROADMAP.md
…schema 17, scan default trust) main gained specs/119-scan-default-trust (number collision; 120/121 are claimed by other branches) and telemetry schema 16 (101-tpa-db). The spec moves to 122, its telemetry bump becomes schema 17, and the starter flow now covers the scan default: a clean admission scan unquarantines through the unchanged door.
…ctivation-1fad2a # Conflicts: # ROADMAP.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design-only PR for growth experiment E3, day-two activation: Spec 122 in
specs/122-day-two-activation/(it was drafted as 119). It contains no code. Implementation is split into five PRs (plan.md D7).What the spec does
timeviauvx, orsequentialthinkingvianpxas the fallback. It goes through the unchanged catalog door, so it is quarantined by default. The card shows the exact command and the isolation mode, and nothing runs until the user clicks "Add and inspect". The user then approves the captured tools in place, bound to the review (Spec 117expected_hashes+expected_incarnation). Nothing is auto-approved.fetchandeverythingare excluded, becauseeverythingshipsget-env, which dumps all environment variables. The same offer appears, not pre-selected, on Web Home and on the native Home.digestonGET /activity/summary, shown as a Web Home card, a tray glance line andmcpproxy activity summary --since 7d. It reports calls brokered by client, tool changes held for review, blocks by class (quarantine / profile / other), and calls with secrets detected. Everything is computed locally.day_twoobject plusactivation.first_tool_indexed_ever. There are no new identifiers, and the PII scan rejects unknown keys and values. This part ships first (PR-A), so baseline data exists before the UI does.Success bar: at least 82% of new installs reach tools-indexed (same heartbeat-sampled instrument as the 71.5% baseline), and D7 on the IP key is at least 18%. The kill rule is in the spec.
Changes after the reviews (2026-10-25 merge with main), not re-reviewed
specs/119-scan-default-trust, and 120 and 121 are claimed by other branches.scandefault trust mode (Spec 119). A clean admission scan unquarantines it through the unchanged door, and the step goes straight to "ready". Undermanual, or after a non-clean verdict, the in-place bound approval applies. FR-003, FR-006, A2 and US1 scenario 8 were updated accordingly. The starter still adds no trust path of its own.Riskiest assumption
The spec assumes that the 36% vs 66% one-and-done gap between installs that index a tool and those that don't is caused by having a working tool. It could instead reflect intent: people who add a real server already had a reason to come back. A
timestarter will lift "tools indexed" almost mechanically, so the primary metric can move while retention does not (a Goodhart risk). That is why D7 is co-primary, why the kill rule requires both metrics to move, and whyfirst_tool_indexed_everis reported separately from the baseline-comparabletool_countseries. A second risk is that the explicit approval click becomes the new drop-off. It is measured (approval_abandoned, measured from capture completion), but by design there is no auto-approve fallback.Cross-model review (OpenCode
github-copilot/gpt-6.1-sol,--variant high)entered_hold, upgrade observation,referenceregistry override fail-closeddispatchedfact, post-dispatch blocks, R8 emit sites, abandonment clock, per-client connect mode, unchanged wizard completion, response envelopesdigest.windowprompts/getcounted as a response blockI verified every finding against the code before fixing it. None was rejected as a false positive. The plan took 6 of the 10 allowed rounds.
speckit.analyze: 100% FR coverage (32 FRs → 78 tasks in 7 phases mapped to 5 PRs). It found one CRITICAL, now recorded: constitution IV says Docker by default, but the product default is off. This is pre-existing and recorded in the plan's Complexity Tracking. The starter follows the global setting and does not widen it. There was also 1 MEDIUM enum gap and 2 LOW items, all fixed.Assumptions made without asking (zero-interruption policy)
All of them are in spec.md "Clarifications" / "Assumptions" and in research.md R1-R12. The main ones:
Follow-ups (not in this PR)
launcher_missingis above 15%.