Repository navigation
fix(cli): apply imports before rendering structured output - #1729
Merged
Merged
Conversation
Deploying mcpproxy-docs with
|
| Latest commit: |
dc8c9b7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://25fccae0.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://codex-ux-import-output.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 39721997328 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix UX audit F1:
upstream import -o jsonand-o yamlpreviously reported imported servers without applying them. All output formats now execute the same import before rendering, expose planned/applied counts and dry-run state, and return nonzero with per-server details for partial failures. Invalid previews report validation failure and explicitly make no changes.Testing
go test ./cmd/mcpproxy ./internal/configimport -count=1and focused import suite with-racepass.claude-fable-5-1) review: VERDICT: PASS at dc8c9b7, after correcting dry-run wording and Windows/root test portability.qa-gate: success. CI must pass before merge.Example partial outcome:
planned=1 applied=1 failed=1, exit 1. Invalid dry-run:planned=1 applied=0 failed=1, exit 1,validation failed ... no changes made.