Repository navigation
fix(ui): distinguish tool approval from callable readiness - #1730
Merged
Merged
Conversation
Deploying mcpproxy-docs with
|
| Latest commit: |
37da17c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f5ffdb0.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://codex-ux-callable-readiness.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 39722335769 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix UX audit F3/F7 on Web and CLI: selective approval previously left a headline saying all tools were approved, and profile tier counts looked like callable counts. Review now separates approved/unblocked tools from blocked tools and reports connected, connecting, authentication-required, error, disconnected, disabled, or quarantined state. Profile cards use the existing effective-tools projection for callable/held/hidden counts and label policy tier counts as “allowed by profile.”
Readiness refreshes are bounded, handle transient failures and connection events, preserve pending tool selections, and stop after unmount. CLI approval explains that policy completion can precede connection/discovery. Enforcement is unchanged.
Testing
go vet ./cmd/mcpproxy ./internal/runtimepass.claude-fable-5-1) review: VERDICT: PASS at 37da17c after lifecycle and readiness-state fixes.qa-gate: success. CI must pass before merge.Scope
Native Swift review wording remains a separate follow-up requiring native QA; this PR addresses the audited Web/CLI surfaces.
Live fixture excerpt (connected; one tool blocked):
{"counts":{"visible":2,"hidden":0,"callable":1,"by_reason":{"tool_approval":1}}}Review displays
1 approved and unblocked · 1 blocked of 2and separately reportsconnected; after disconnect, callable becomes0and the review reports the actual connection state.