Repository navigation
fix(cli): preserve MCP call results and structured errors - #1731
Merged
Merged
Conversation
Deploying mcpproxy-docs with
|
| Latest commit: |
0035525
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bb3a7ba2.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://codex-ux-cli-result-parity.mcpproxy-docs.pages.dev |
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 39722580601 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix UX audit F4: CLI calls converted content arrays to Go map text and dropped MCP result metadata. CLI now opts into a full MCP result envelope and preserves content, structuredContent, isError, and _meta. Existing REST consumers retain their response shape. Runtime JSON failures remain machine-readable; MCP isError results return nonzero in JSON and pretty output, without a false success message.
Testing
go vet ./cmd/mcpproxypass.claude-fable-5-1) review: VERDICT: PASS at 0035525 after error-envelope, pretty-exit and unreachable-code fixes.qa-gate: success. CI must pass before merge.The opt-in
X-MCPProxy-Result-Envelope: 1compatibility contract is documented indocs/cli-output-formatting.md; tool refusal/security classification stays ahead of envelope preservation.Live fixture CLI excerpt (same semantic result as MCP):
{"content":[{"type":"text","text":"{\"project\":\"audit-fixture\",\"status\":\"healthy\"}"},{"type":"image","data":"YWJj","mimeType":"image/png"}],"isError":false,"structuredContent":{"count":2,"status":"healthy"},"_meta":{"fixture":"cli-live"}}A fixture
isError: truereturns exit1in both JSON and pretty modes.