Repository navigation
ci(pr-build): give go test a 20m package timeout - #1735
Merged
Merged
Conversation
The Build Binaries job ran go test ./... with Go's default 10m per-package limit. internal/server now takes close to that on a loaded runner, so the job failed with "panic: test timed out after 10m0s" while every test was passing (PR #1718, run 39776808883). Match the 20m the unit-tests workflow already uses.
Deploying mcpproxy-docs with
|
| Latest commit: |
1016978
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a074976c.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://ci-pr-build-test-timeout.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 39783264922 --repo smart-mcp-proxy/mcpproxy-go
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Build Binaries job in
pr-build.ymlrunsgo test ./...with Go's default 10-minute per-package timeout.internal/servernow takes close to that on a loaded runner, so the job failed on PR #1718 (run 39776808883) withpanic: test timed out after 10m0swhile every test was passing; the test running at that moment had been going for 10 seconds. The same job passed on the previous head of that PR and on the run in between, so this is a budget, not a hang.Set
-timeout 20mon bothgo testlines, matching whatunit-tests.ymlalready uses. CI-only change.