Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/logs/sanitizer.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ func (s *SecretSanitizer) registerDefaultPatterns() {
if len(parts) != 3 {
return "****"
}
if len(parts[2]) < 4 {
return parts[0] + ".***.***"
}
// Show first part (header) but mask payload and signature
return parts[0] + ".***." + parts[2][len(parts[2])-4:]
},
Expand Down
28 changes: 28 additions & 0 deletions internal/logs/sanitizer_jwt_short_signature_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
package logs

import (
"strings"
"testing"
)

// The jwt regex accepts a 1-3 character signature segment; masking it must
// not slice out of range (a panic inside the zap core takes the caller down).
func TestSanitizer_JWTShortSignatureDoesNotPanic(t *testing.T) {
s := newTestSanitizer()
const payload = "eyJzdWIiOiIxIn0"
for _, sig := range []string{"x", "ab", "abc"} {
in := "jwt eyJhbGciOiJub25lIn0." + payload + "." + sig
var out string
func() {
defer func() {
if r := recover(); r != nil {
t.Errorf("sanitizeString(%q) panicked: %v", in, r)
}
}()
out = s.sanitizeString(in)
}()
if strings.Contains(out, payload) {
t.Errorf("payload leaked: %q", out)
}
}
}
Loading