Skip to content

fix(logs): mask sk-proj/sk-svcacct/sk-admin OpenAI keys #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dumbris merged 1 commit into from
Oct 25, 2026
Merged

fix(logs): mask sk-proj/sk-svcacct/sk-admin OpenAI keys #1762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/logs/sanitizer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,12 @@ func (s *SecretSanitizer) registerDefaultPatterns() {
},
})

// OpenAI API keys (sk-...)
// OpenAI API keys: legacy sk-..., and the current sk-proj-/sk-svcacct-/
// sk-admin- forms whose suffix also carries '_' and '-'. The legacy branch
// stays alphanumeric so sk-ant- keys still reach anthropic_key below.
s.patterns = append(s.patterns, &secretPattern{
name: "openai_key",
regex: regexp.MustCompile(`\b(sk-[A-Za-z0-9]{20,})\b`),
regex: regexp.MustCompile(`\b(sk-(?:(?:proj|svcacct|admin)-[A-Za-z0-9_\-]{20,}|[A-Za-z0-9]{20,}))\b`),
maskFunc: func(key string) string {
if len(key) <= 5 {
return "****"
Expand Down
27 changes: 27 additions & 0 deletions internal/logs/sanitizer_openai_project_key_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package logs

import (
"strings"
"testing"
)

func TestSanitizer_OpenAIProjectAndServiceAccountKeys(t *testing.T) {
s := newTestSanitizer()
for _, key := range []string{
"sk-proj-AbCdEf1234567890_GhIjKl-MnOpQrStUvWxYz0123456789",
"sk-svcacct-AbCdEf1234567890_GhIjKl-MnOpQrStUvWxYz0123456789",
"sk-admin-AbCdEf1234567890GhIjKlMnOpQrStUvWxYz0123456789",
"sk-AbCdEf1234567890GhIjKlMnOpQrStUvWxYz0123456789", // legacy
} {
out := s.sanitizeString("using key " + key + " for upstream")
if strings.Contains(out, key) || strings.Contains(out, key[12:]) {
t.Errorf("OpenAI key leaked: %q", out)
}
}

// sk-ant- keys keep their own, longer-prefix mask.
ant := "sk-ant-api03-" + strings.Repeat("aB3dE", 8)
if out := s.sanitizeString("key " + ant); !strings.Contains(out, "sk-ant-api***") {
t.Errorf("anthropic key no longer masked by anthropic_key: %q", out)
}
}
Loading