[rudycelekli]

Bug

mcpproxy feedback exits 0 when the submission was not accepted. SubmitFeedback returns Success: false without an error in two cases: the backend answers 2xx with {"success": false, "error": "..."}, or it answers a non-JSON 3xx. runFeedback prints "Feedback submission failed: ..." (in text mode) and then returns nil. In -o json mode it prints the JSON and also returns nil. Scripts and CI wrappers therefore treat a rejected submission as sent.

Trigger

With the telemetry endpoint returning 200 {"success":false,"error":"rejected by backend"}:

$ mcpproxy feedback "the search results could be more relevant" --category bug
Feedback submission failed: rejected by backend
$ echo $?
0

Fix

After rendering the output, return feedback submission failed: <error> when resp.Success is false, so the exit code is non-zero in both text and JSON modes. The text branch no longer prints its own failure line, because cobra prints the returned error. The success path is unchanged.

Test

TestRunFeedback_RejectedSubmissionReturnsError points the telemetry endpoint at an httptest server that returns {"success":false}, and asserts that runFeedback returns an error.

Commands run

• go vet ./cmd/mcpproxy: clean
• go test -count=1 ./cmd/mcpproxy: ok (needs cgo; run with SDKROOT set to the macOS 26.5 SDK locally)
• Without the fix, the new test fails with runFeedback returned nil for a submission the backend rejected.
• gofmt -l on the edited files: no output

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[Dumbris]

Verified: the PR test fails on main for the reason described and passes on this branch merged with main; race tests for the touched packages and CI lint (bare and server tags) are clean. Also built and tested together with the rest of this batch, independently reviewed, and cross-reviewed with a second model.

[Dumbris]

Merged. Thank you, @rudycelekli! mcpproxy feedback exits non-zero when the backend rejects the submission.