Repository navigation
ci(release): retry-sign-release waits 3h for SignPath approval, like release.yml - #1795
Merged
Merged
Conversation
…ndow as release.yml The retry workflow waited only 3600s for the manual release-signing approval, so a re-dispatch after a timed-out release run (v0.72.0, run 40409167558) died again after 1h01 while both requests were still WaitingForApproval. release.yml already waits 10800s (4ee7b10); match it. The job has no timeout-minutes, so the 6h default still covers download + sign + upload. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Dumbris
enabled auto-merge (squash)
October 26, 2026 23:10
Deploying mcpproxy-docs with
|
| Latest commit: |
8cf3083
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c9a96f8a.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://ci-retry-sign-timeout-parity.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 40417856722 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
retry-sign-release.ymlwaits only 3600 s for the SignPathrelease-signingapproval, whilerelease.ymlwaits 10800 s (since 4ee7b10). The v0.72.0 retry (run 40409167558) timed out after 1h01 on both arches with the requests stillWaitingForApproval, so a re-dispatch gives the approver a third of the window the original run has.Change
One line:
wait-for-completion-timeout-in-seconds: 3600 → 10800in the retry workflow. The job has notimeout-minutes, so GitHub's 6h default still covers download + signing + upload.No code change; workflow_dispatch only.
🤖 Generated with Claude Code