Repository navigation
docs(docker): compose example with stdio servers in sidecars (#1707) - #1885
Merged
Merged
Conversation
Deploying mcpproxy-docs with
|
| Latest commit: |
b1e47c8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9eaed562.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://docs-compose-stdio-sidecars.mcpproxy-docs.pages.dev |
1 task done
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 43081990498 --repo smart-mcp-proxy/mcpproxy-go
|
…ect health-check docs
…ot run test.sh kept an inherited COMPOSE_PROJECT_NAME, so it could still target a deployment and delete its volume. The project is now fixed and passed with -p on every call. The isolation probes print their answer, so a probe that could not run fails the test. gen-secrets.sh refuses a secret entry that is not a regular file.
Dumbris
enabled auto-merge (squash)
November 11, 2026 18:58
Dumbris
added a commit
that referenced
this pull request
Nov 16, 2026
…n macOS runners (#1890) ## Summary Two `internal/server` tests failed on macOS runners on unrelated PRs (#1885, #1887). Both are races in the tests, not in production code. This PR fixes them. Test-only. ## Causes and fixes **`TestSearchTools_WithholdsApprovalLockedHits`** returned only `cedar:pending_item` when `orchid:read_item` was also expected. - After `PhaseReady` the runtime starts background tool indexing, whose first step deletes index entries for servers the upstream manager does not know. - The test seeds two hand-made servers into the index right after `PhaseReady`, so the cleanup could delete a seeded document mid-seeding. - Reproduced locally with `GOMAXPROCS=1 go test -race -count=40`: failed within the first two runs. - Fix: a `newSettledConsistencyServer` fixture waits for `PhaseReady` and for the cleanup's completion log line before the test seeds anything. `TestSearchTools_AnnotationsSurviveToTier` seeds the same way and now uses it too. **`TestTPAFetchLifecycle_ActivatesReprotectsAndRefusesBadReleases`** failed with "exactly one cycle reported activated: expected 1, actual 0". - The test waited for the bundle source to flip, which happens inside the fetch leg. The telemetry counter is incremented later, by the observer that runs after the cycle is recorded. - Reproduced deterministically by delaying that observer by 400 ms (not part of this PR). - Fix: poll until the counter reaches 1, then keep the exact `== 1` assertion. ## Not fixed here The `test timed out after 40m0s` failure on #1886 was not a hang. The whole `internal/server` package ran 40 minutes on a slow runner; the same job passed in 20 minutes on retry. A healthy macOS run already uses about half the 40-minute budget. Raising the timeout or trimming the fixed 12-second waits in the upstream-add tests is a separate decision. ## Testing - `GOMAXPROCS=1 go test -race -count=100 -run TestSearchTools_WithholdsApprovalLockedHits ./internal/server/`: pass. - Both search tests together, `-race -count=15`: pass. - The fetch lifecycle test, `GOMAXPROCS=1 -race`: 15 of 15 runs passed. - `golangci-lint` v2 on `./internal/server/...`: 0 issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the layout from #1707 as a ready-to-copy, CI-tested example: mcpproxy with each stdio MCP server in its own sidecar container on an
internal: truenetwork.examples/compose-stdio-sidecars/: compose file, sidecar Dockerfile (supergateway 4.2.0,--stateful,--apiKeyFile,/healthzhealthcheck), minimalmcp_config.json,gen-secrets.sh,test.sh.docs/operations/compose-stdio-sidecars.md: what the layout protects (a compromised stdio package cannot read/data, the API key or the OAuth token database), the supergateway stateless-default pitfall, and the known limits..github/workflows/compose-example.yml: path-filtered job that validates the compose file and runs the stack end to end.Images are pinned by digest (
mcpproxy-serverv0.73.0,node:24-bookworm-slim). Keys are file secrets viaMCPPROXY_API_KEY_FILEand${file:}./datais mounted only in the proxy, no container gets a docker socket,stop_grace_period: 60s.Verification
docker compose config -qpasses../test.shpassed locally (Docker 29.4.0, Compose 5.1.2): tools listed through the proxy with the API key,/mcpwithout a credential returns 401, the sidecar without its key returns 401, the sidecar has no egress, no/dataand no docker socket.actionlintclean; docs site builds.server-everything.Notes
Closes #1707