Skip to content

patch propose deprecated php8.6 - #1206

Open
klaoun2 wants to merge 3 commits into
smarty-php:masterfrom
klaoun2:klaoun2-patch-deprecated
Open

patch propose deprecated php8.6#1206
klaoun2 wants to merge 3 commits into
smarty-php:masterfrom
klaoun2:klaoun2-patch-deprecated

Conversation

@klaoun2

@klaoun2 klaoun2 commented Aug 17, 2026

Copy link
Copy Markdown

hello
i propose this pr

@Amaury

Amaury commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Did you test your code before submitting it? This PR does not parse. The three commits copy the function signatures from the php.net manual into the call sites:

$mb_reg_charset = mb_regex_encoding(?string $encoding = null):
$parts = mb_split(preg_quote(string $search), string $subject ?? "") ?: array();

Parameter types and defaults are only legal in a declaration, plus the statement terminators are : instead of ;.

php -l src/functions.php fails, and since Composer autoloads that file via files, this is a fatal error on every PHP version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants