fix warnings

Author: smdn

tests/Smdn.TPSmartHomeDevices.Tapo/Smdn.TPSmartHomeDevices.Tapo.Protocol/PseudoTapoDevice.KLAP.cs

@@ -310,7 +310,7 @@ await request.InputStream.ReadToEndAsync().ConfigureAwait(false),
 
     var requestJsonDocument = JsonDocument.Parse(session.DecryptionBuffer.WrittenMemory);
 
-    var contentEncoding = utf8nobom;
+    var contentEncoding = Utf8NoBom;
     var responseString = JsonSerializer.Serialize(
       FuncGenerateKlapRequestResponse?.Invoke(session, requestJsonDocument, sequenceNumber.Value)
     );

tests/Smdn.TPSmartHomeDevices.Tapo/Smdn.TPSmartHomeDevices.Tapo.Protocol/PseudoTapoDevice.cs

@@ -123,7 +123,7 @@ public AuthorizedSession(string token, UnauthorizedSession session)
     }
   }
 
-  private static readonly Encoding utf8nobom = new UTF8Encoding(false);
+  private static readonly Encoding Utf8NoBom = new UTF8Encoding(false);
 
   private static string CreateEndPointHttpUrl(IPEndPoint endPoint)
     => endPoint.AddressFamily == AddressFamily.InterNetworkV6
@@ -250,7 +250,7 @@ public EndPoint Start(
 
     taskProcessListener = Task.Run(ProcessListenerAsync);
 
-    return EndPoint!;
+    return EndPoint;
   }
 
   public IDeviceEndPoint GetEndPoint()
@@ -269,7 +269,7 @@ private async Task ProcessListenerAsync()
         HttpListenerContext? context = null;
 
         try {
-          context = await listener!.GetContextAsync().ConfigureAwait(false);
+          context = await listener.GetContextAsync().ConfigureAwait(false);
         }
         catch (ArgumentException) when (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) {
           return; // disposed
@@ -324,7 +324,7 @@ string content
   )
   {
     const string ContentType = "text/plain";
-    var contentEncoding = utf8nobom;
+    var contentEncoding = Utf8NoBom;
 
     try {
       response.StatusCode = (int)statusCode;
@@ -581,7 +581,7 @@ private static async Task WriteJsonContentAsync<TResponseContent>(
   )
   {
     const string ContentType = "application/json";
-    var contentEncoding = utf8nobom;
+    var contentEncoding = Utf8NoBom;
 
     try {
       response.StatusCode = (int)statusCode;
@@ -657,7 +657,7 @@ JsonDocument requestJsonDocument
 
     var session = UnauthorizedSession.Create(
       state: State,
-      remoteEndPoint: remoteEndPoint!,
+      remoteEndPoint: remoteEndPoint,
       sessionId: sessionId,
       expiresOn: sessionExpiresOn,
       key: keyAndIv.AsSpan(0, 16).ToArray(),
@@ -731,7 +731,7 @@ ITapoPassThroughResponse passThroughResponse
   )
   {
     const string ContentType = "application/json";
-    var contentEncoding = utf8nobom;
+    var contentEncoding = Utf8NoBom;
 
     try {
       response.StatusCode = (int)HttpStatusCode.OK;
@@ -759,9 +759,9 @@ ITapoPassThroughResponse passThroughResponse
       type: typeOfSecurePassThroughResponse,
       bindingAttr: BindingFlags.Instance | BindingFlags.Public,
       binder: null,
-      args: new object[] { errorCode, passThroughResponse },
+      args: [ errorCode, passThroughResponse ],
       culture: null
-    )!;
+    );
 
     await JsonSerializer.SerializeAsync(
       utf8Json: buffer,

tests/Smdn.TPSmartHomeDevices.Tapo/Smdn.TPSmartHomeDevices.Tapo.Protocol/TapoClient.Authentication.cs

@@ -7,7 +7,6 @@
 using System.Linq;
 using System.Net;
 using System.Net.Sockets;
-using System.Runtime.InteropServices;
 using System.Security.Cryptography;
 using System.Text;
 using System.Text.Json;
@@ -184,7 +183,7 @@ public void AddCredential(ITapoCredentialIdentity identity, TapoCredential? cred
       if (!credentials.TryGetValue(identity, out var credential))
         throw new TapoCredentialNotFoundException();
 
-      return credential!;
+      return credential;
     }
 
     public ITapoCredential GetCredential(ITapoCredentialIdentity? identity)

tests/Smdn.TPSmartHomeDevices.Tapo/Smdn.TPSmartHomeDevices.Tapo.Protocol/TapoClient.cs

@@ -41,8 +41,8 @@ public void SetUp()
       );
     }
 
-    defaultCredentialProvider = services?.BuildServiceProvider()!.GetRequiredService<ITapoCredentialProvider>();
-    defaultHttpClientFactory = services?.BuildServiceProvider()!.GetService<IHttpClientFactory>();
+    defaultCredentialProvider = services?.BuildServiceProvider().GetRequiredService<ITapoCredentialProvider>();
+    defaultHttpClientFactory = services?.BuildServiceProvider().GetService<IHttpClientFactory>();
 
     var servicesForDefaultKlapCredentialProvider = new ServiceCollection();
 
@@ -51,7 +51,7 @@ public void SetUp()
       password: "pass"
     );
 
-    defaultKlapCredentialProvider = servicesForDefaultKlapCredentialProvider.BuildServiceProvider()!.GetRequiredService<ITapoCredentialProvider>();
+    defaultKlapCredentialProvider = servicesForDefaultKlapCredentialProvider.BuildServiceProvider().GetRequiredService<ITapoCredentialProvider>();
   }
 
   [Test]

tests/Smdn.TPSmartHomeDevices.Tapo/Smdn.TPSmartHomeDevices.Tapo/TapoDevice.cs

@@ -7,7 +7,6 @@
 using System.Net.Http;
 using System.Net.NetworkInformation;
 using System.Net.Sockets;
-using System.Runtime.InteropServices;
 using System.Text;
 using System.Text.Json.Serialization;
 using System.Threading;
@@ -74,7 +73,7 @@ public void Create_WithCredentialProvider_ByICredentialProvider()
       () => {
         using var device = TapoDevice.Create(
           deviceEndPoint: new StaticDeviceEndPoint(new IPEndPoint(IPAddress.Loopback, 0)),
-          credential: services?.BuildServiceProvider()!.GetRequiredService<ITapoCredentialProvider>()
+          credential: services?.BuildServiceProvider().GetRequiredService<ITapoCredentialProvider>()
         );
       }
     );
@@ -166,7 +165,7 @@ public async Task Create_WithMacAddress_IServiceProvider()
       macAddress: PhysicalAddress.None,
       "user@mail.test",
       "password",
-      serviceProvider: services!.BuildServiceProvider()
+      serviceProvider: services.BuildServiceProvider()
     );
 
     Assert.That(device.EndPoint, Is.Not.Null);
@@ -186,7 +185,7 @@ public void Create_WithMacAddress_IServiceProvider_IDeviceEndPointFactoryNotRegi
         macAddress: PhysicalAddress.None,
       "user@mail.test",
       "password",
-        serviceProvider: services!.BuildServiceProvider()
+        serviceProvider: services.BuildServiceProvider()
       )
     );
   }