Skip to content

fix: parameterize SQL queries in the db layer #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrueFurina wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

fix: parameterize SQL queries in the db layer #2028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spiderfoot/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1536,8 +1536,8 @@ def scanElementSourcesDirect(self, instanceId: str, elementIdList: list) -> list
tbl_event_types st \
WHERE c.scan_instance_id = ? AND c.source_event_hash = s.hash AND \
s.scan_instance_id = c.scan_instance_id AND st.event = s.type AND \
t.event = c.type AND c.hash in ('%s')" % "','".join(hashIds)
qvars = [instanceId]
t.event = c.type AND c.hash in (%s)" % ",".join("?" * len(hashIds))
qvars = [instanceId] + hashIds

with self.dbhLock:
try:
Expand Down Expand Up @@ -1585,8 +1585,8 @@ def scanElementChildrenDirect(self, instanceId: str, elementIdList: list) -> lis
FROM tbl_scan_results c, tbl_scan_results s, tbl_event_types t \
WHERE c.scan_instance_id = ? AND c.source_event_hash = s.hash AND \
s.scan_instance_id = c.scan_instance_id AND \
t.event = c.type AND s.hash in ('%s')" % "','".join(hashIds)
qvars = [instanceId]
t.event = c.type AND s.hash in (%s)" % ",".join("?" * len(hashIds))
qvars = [instanceId] + hashIds

with self.dbhLock:
try:
Expand Down