Fix volume slider snapping back on iOS - #167
Open
DanielFarber wants to merge 1 commit into
Open
DanielFarber wants to merge 1 commit into
DanielFarber wants to merge 1 commit into
Conversation
On iOS Safari, lifting a finger off a Slider without moving it first
synthesizes a mouse{move,down,up} sequence after the touch gesture ends.
MUI v7's mouse-event-based Slider turns that synthetic mousedown into an
extra onChange carrying the drag's start value, which snaps the
controlled volume slider back to where the drag began
(mui/material-ui#31869, mui/material-ui#38311).
Add isSpuriousIOSSliderChange() in a new util module and have both
handleVolumeChange handlers bail out when the change originates from a
mousedown on iOS. The upstream fix (Slider rewritten to pointer events)
only landed in @mui/material v9, which is two majors away.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS Safari, lifting a finger off a Slider without moving it first synthesizes a mouse{move,down,up} sequence after the touch gesture ends. MUI v7's mouse-event-based Slider turns that synthetic mousedown into an extra onChange carrying the drag's start value, which snaps the controlled volume slider back to where the drag began (mui/material-ui#31869, mui/material-ui#38311).
Add isSpuriousIOSSliderChange() in a new util module and have both handleVolumeChange handlers bail out when the change originates from a mousedown on iOS. The upstream fix (Slider rewritten to pointer events) only landed in @mui/material v9, which is two majors away.