Repository navigation
SNOW-3192362: Fix pyenv version match for plain 3.x also matching free-threaded installs - #3005
Merged
Merged
Conversation
…talls 03630e7 anchored the "*t" pyenv-version grep pattern but left the plain pattern unanchored, so PYTHON_VERSION=3.14 (pattern ^3\.14) matched both 3.14.0 and 3.14.0t. Combined with tail -1, the plain iteration picked the free-threaded install, causing both the 3.14 and 3.14t loop iterations to build with the same interpreter and silently overwrite the cp314-cp314 wheel with cp314-cp314t in the shared dist/ dir. Anchor the plain pattern the same way the *t branch already is, so 3.14 only matches 3.14/3.14.x and never 3.14.xt.
sfc-gh-fpawlowski
changed the title
sfc-gh-fpawlowski
marked this pull request as ready for review
August 18, 2026 08:22
![snowflake-security-bot[bot]](https://avatars.githubusercontent.com/u/140554735?s=60&v=4){kind=small}
sfc-gh-makowalski
approved these changes
Aug 18, 2026
sfc-gh-fpawlowski
enabled auto-merge (squash)
August 18, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
03630e74anchored the free-threaded (*t) pyenv-version grep pattern inci/build_darwin.shbut left the plain-version pattern unanchored.PYTHON_VERSION=3.14, the resulting pattern^3\.14matches both3.14.0and3.14.0t. Combined with thetail -1selection (needed to prefer the highest free-threaded patch), the plain3.14loop iteration now silently resolves to the free-threaded interpreter.3.14and3.14titerations then build with the same interpreter and write the same-namedcp314-cp314twheel into the shareddist/dir — the second write overwrites the first, so the regularcp314-cp314wheel is never produced. This matches the observed S3 output formainbuild03630e7414056fe455ef4d7416d57186b75df44c, where every (arch, macOS version) combo has acp314-cp314twheel but nocp314-cp314wheel.*tbranch already is, so3.14only matches3.14/3.14.xand never3.14.xt.Test plan
bash -n ci/build_darwin.sh— syntax check passespyenv versions --barelist containing3.14.0and3.14.0t: plain pattern matches only3.14.0,*tpattern matches only3.14.0t./ci/build_darwin.sh "3.14 3.14t"and confirm two distinct wheels (cp314-cp314andcp314-cp314t) are producedMarked as draft pending the on-node verification above.