Repository navigation
Keep custom public PKCE client_id in OAuth authorization code - #3012
Open
Hashim1999164 wants to merge 2 commits into
Open
Hashim1999164 wants to merge 2 commits into
Hashim1999164 wants to merge 2 commits into
Conversation
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Hashim1999164
force-pushed
the
fix/oauth-public-pkce-client-id
branch
from
October 2, 2026 21:32
a4112e5 to
ecefd6f
Compare
Author
|
rebased onto latest main. kept the public PKCE client_id fix and slotted the DESCRIPTION note under v4.8.0. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3011
The eligibility check treated a missing client_secret as a reason to replace a supplied client_id with LOCAL_APPLICATION. Public PKCE clients keep the custom client_id, skip HTTP Basic, and send client_id in the token request body.
Test plan
Ran pytest test/unit/test_auth_oauth_auth_code.py and test/unit/test_auth_oauth_credentials.py locally (34 passed).