Repository navigation
Name the missing pandas extra when fetch_pandas fails - #3043
Open
Hashim1999164 wants to merge 1 commit into
Open
Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
installed_pandas requires both pandas and pyarrow, but the error always blamed pandas. Report whichever package failed to import so users who already have pandas know to install pyarrow.
![snowflake-security-bot[bot]](https://avatars.githubusercontent.com/u/140554735?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installed_pandasis only true when both pandas and pyarrow import successfully, butcheck_can_use_pandasalways said pandas was missing. That made Snowparkto_pandas()failures blame pandas even when pandas was already installed and only pyarrow was absent (see snowflakedb/snowpark-python#4383).This change imports the two packages separately, tracks which one failed, and puts that name in the error message.
Test plan
pytest test/integ/pandas_it/test_unit_options.py(covers pyarrow-only missing case and message text)fetch_pandas_allwith pandas installed and pyarrow missing names pyarrow in the error