test(browser-plugin-media): cover updateMediaTracking mid-session empty-string stripping [AISP-1625] - #1497
Draft
snowplow-claude-review[bot] wants to merge 1 commit into
Conversation
…plow-javascript-tracker)
|
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Jest test for the
updateMediaTrackingmid-session path in the media plugin.buildMediaPlayerEntityinplugins/browser-plugin-media/src/core.tsalready deleteslabel,playerType, andqualitywhen they equal''before the entity is emitted. The existing tests intest/api.test.tsverified this only atstartMediaTrackingtime. This PR adds the missing case: a session started with a non-empty label, followed byupdateMediaTracking({ label: '' })andtrackMediaPlay, asserts thatlabelis absent from the media player context entity on the subsequent event.Why it matters
The
updateMediaTrackingpath merges the supplied options into player state and then routes throughbuildMediaPlayerEntityon every subsequent track call (api.ts:109-114). Without this test, a regression in the state-merge path could reintroduce the empty-string emission without any test failure.What to review
plugins/browser-plugin-media/test/api.test.ts: the new test block — check that the assertion (labelkey absent from the entity properties) correctly targets the right context entity and property name.Draft PR opened for review — please verify and run CI before merging.