Skip to content

test(browser-plugin-media): cover updateMediaTracking mid-session empty-string stripping [AISP-1625] #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
snowplow-claude-review wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test(browser-plugin-media): cover updateMediaTracking mid-session empty-string stripping [AISP-1625] #1497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions plugins/browser-plugin-media/test/api.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,20 @@ describe('Media Tracking API', () => {
});
});

it('strips empty string label from media player entity when updated mid-session via updateMediaTracking', () => {
startMediaTracking({
id,
session: false,
player: { label: 'My Video' },
});

updateMediaTracking({ id, player: { label: '' } });
trackMediaPlay({ id });

const playerContext = eventQueue[0].context[0].data;
expect(playerContext).not.toHaveProperty('label');
});

it('tracks error event', () => {
startMediaTracking({ id, session: false });

Expand Down
Loading