Add request body rewind preparation

Author: ioquatix

lib/protocol/http/request.rb

@@ -153,14 +153,9 @@ def idempotent?
 				return false
 			end
 
-			# Prepare the request body to be sent again, if it is safe to retry.
-			# @returns [Boolean] Whether the request was prepared for retry.
-			def retry!
-				# Only idempotent request methods can be retried safely.
-				if @method == Methods::POST || @method == Methods::PATCH || @method == Methods::CONNECT
-					return false
-				end
-				
+			# Rewind the request body so it can be sent again.
+			# @returns [Boolean] Whether the request body was rewound.
+			def rewind!
 				# Requests without a body can be sent again immediately.
 				if body = @body
 					# Empty, non-rewindable bodies have nothing left to send.
@@ -181,6 +176,17 @@ def retry!
 				return true
 			end
 
+			# Prepare the request body to be sent again, if it is safe to retry.
+			# @returns [Boolean] Whether the request was prepared for retry.
+			def retry!
+				# Only idempotent request methods can be retried safely.
+				if @method == Methods::POST || @method == Methods::PATCH || @method == Methods::CONNECT
+					return false
+				end
+				
+				return self.rewind!
+			end
+			
 			# Convert the request to a hash, suitable for serialization.
 			#
 			# @returns [Hash] The request as a hash.

test/protocol/http/request.rb

@@ -160,6 +160,32 @@
 			end
 		end
 
+		with "#rewind!" do
+			it "allows requests without a body" do
+				expect(request.rewind!).to be == true
+			end
+			
+			with "request with a rewindable body" do
+				let(:request) {subject["POST", "/submit", body: "content"]}
+				
+				it "rewinds the body" do
+					expect(request.body.read).to be == "content"
+					
+					expect(request.rewind!).to be == true
+					expect(request.body.read).to be == "content"
+				end
+			end
+			
+			with "request with a non-rewindable body" do
+				let(:body) {Protocol::HTTP::Body::Readable.new}
+				let(:request) {subject.new(nil, nil, "PUT", "/resource", nil, headers, body)}
+				
+				it "does not rewind" do
+					expect(request.rewind!).to be == false
+				end
+			end
+		end
+		
 		with "#retry!" do
 			it "allows idempotent requests without a body" do
 				expect(request.retry!).to be == true