Complete coverage for rebased changes

Author: ioquatix

lib/protocol/http/body/deflate.rb

@@ -111,7 +111,7 @@ def self.for(body, window_size = GZIP, level = DEFAULT_LEVEL)
 				# @returns [String | Nil] the compressed chunk or `nil` if the stream is closed.
 				def read
 					if @stream.finished?
-						return
+						return nil
 					end
 
 					# The stream might have been closed while waiting for the chunk to come in.

lib/protocol/http/body/stream.rb

@@ -203,7 +203,9 @@ def read_until(pattern, offset = 0, chomp: false)
 						split_offset = pattern.bytesize - 1
 
 						@buffer ||= read_next
-						return nil if @buffer.nil?
+						if @buffer.nil?
+							return nil
+						end
 
 						index = nil
 						loop do

test/protocol/http/body/stream.rb

@@ -208,6 +208,14 @@
 		it "can read until a pattern which isn't encountered" do
 			expect(stream.read_until("X")).to be_nil
 		end
+
+		with "empty input" do
+			let(:input) {Protocol::HTTP::Body::Buffered.new}
+
+			it "returns nil" do
+				expect(stream.read_until("X")).to be_nil
+			end
+		end
 	end
 
 	with "#gets" do

test/protocol/http/request.rb

@@ -136,6 +136,22 @@
 			end
 		end
 
+		with "POST request without a body" do
+			let(:request) {subject["POST", "/submit"]}
+
+			it "should not be idempotent" do
+				expect(request).not.to be(:idempotent?)
+			end
+		end
+
+		with "PUT request with a body" do
+			let(:request) {subject["PUT", "/resource", body: "content"]}
+
+			it "should not be idempotent" do
+				expect(request).not.to be(:idempotent?)
+			end
+		end
+
 		it "should have a string representation" do
 			expect(request.to_s).to be == "http://localhost: GET /index.html HTTP/1.0"
 		end