Make HTTP/1.0 persistence assertion meaningful and pin read_body framing checks without a version.

Author: samuel-williams-shopify

test/protocol/http1/connection.rb

@@ -181,7 +181,7 @@
 		end
 
 		it "fails with HTTP/1.0 request with transfer-encoding and content-length" do
-			client.stream.write "GET / HTTP/1.0\r\nHost: localhost\r\nContent-Length: 11\r\nTransfer-Encoding: chunked\r\n\r\nHello World"
+			client.stream.write "GET / HTTP/1.0\r\nHost: localhost\r\nConnection: keep-alive\r\nContent-Length: 11\r\nTransfer-Encoding: chunked\r\n\r\nHello World"
 			client.stream.close
 
 			expect do
@@ -626,6 +626,31 @@
 		end
 	end
 
+	with "#read_body" do
+		# Callers using the original signature do not pass a version, so framing must still be validated without it.
+		it "reads chunked request body without a version" do
+			body = server.read_body({"transfer-encoding" => ["chunked"]}, false)
+			
+			expect(body).to be_a(Protocol::HTTP1::Body::Chunked)
+			expect(server).to be(:persistent)
+		end
+		
+		it "fails with non-chunked request transfer-encoding without a version" do
+			expect do
+				server.read_body({"transfer-encoding" => ["gzip"]}, false)
+			end.to raise_exception(Protocol::HTTP1::BadRequest, message: be =~ /must be chunked/)
+			
+			expect(server).not.to be(:persistent)
+		end
+		
+		it "reads non-chunked response transfer-encoding until closed without a version" do
+			body = client.read_body({"transfer-encoding" => ["gzip"]}, true)
+			
+			expect(body).to be_a(Protocol::HTTP1::Body::Remainder)
+			expect(client).not.to be(:persistent)
+		end
+	end
+	
 	with "#write_chunked_body" do
 		let(:chunks) {["Hello", "World"]}
 		let(:body) {::Protocol::HTTP::Body::Buffered.wrap(chunks)}