Skip to content

Replace failed rows diagnostics TODO print with a warning - #2748

Open
wunianze666-netizen wants to merge 1 commit into
sodadata:mainfrom
wunianze666-netizen:fix/failed-rows-diagnostics-warning
Open

Replace failed rows diagnostics TODO print with a warning#2748
wunianze666-netizen wants to merge 1 commit into
sodadata:mainfrom
wunianze666-netizen:fix/failed-rows-diagnostics-warning

Conversation

@wunianze666-netizen

@wunianze666-netizen wunianze666-netizen commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace the TODO print(...) in SodaCloud.send_failed_rows_diagnostics() with a structured warning
  • add a regression test that asserts the method does not write to stdout

Why

A bare print() in production code can leak implementation details into CLI output and make automation harder to reason about. Logging keeps the current placeholder behavior visible without polluting standard output.

Validation

  • py -m uv run --package soda-tests pytest soda-tests/tests/unit/test_soda_cloud.py -k test_send_failed_rows_diagnostics_logs_warning_without_stdout -q (1 passed, 34 deselected)
  • the remaining tests in that file reached 30 passed; five integration-backed cases require the optional soda_postgres package in the local environment
  • git diff --check

@sonarqubecloud

Copy link
Copy Markdown

@CLAassistant

CLAassistant commented Jun 12, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants