Fix decorator AST visitor dispatch - #2751
Open
wunianze666-netizen wants to merge 3 commits into
Open
Conversation
|
|
Contributor
Author
|
CI follow-up: all 13 failing Python 3.14 matrix jobs stop in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
ast.NodeVisitorcallback registration soFunctionDefnodes are actually visitedWhy
NodeVisitordispatches function definitions tovisit_FunctionDef, but the helper registeredvisit_function_def. As a result,get_decorators()returned an empty mapping and the intended visitor logic never ran. Correcting the dispatch exposes the existing unconditionalprint(), so the diagnostic is now kept behind the project logger.Validation
py -m uv run --package soda-tests --group dev pytest soda-tests/tests/unit/test_soda_tracer.py -q(1 passed)py -m uv run black --check soda-tests/tests/unit/test_soda_tracer.pygit diff --checkCI note
The GitHub Actions matrix currently stops before test execution in the upstream Get external secrets step because fork runs do not receive the AWS region/Secrets Manager configuration (expected region to be configured for aws.auth#sigv4). The fork-safe pre-commit, lockfile, CLA, Aikido, and SonarCloud checks pass; the targeted unit test above passes locally.