Commit 08eed0e
fix(ios): typing attributes clearing on keystrokes (#773)
# Summary
There was a bug when in some cases, between selection change and a
keystroke, the typing attributes would get cleared, resulting in
unstyled text. More info in the `Screenshots / Videos` section.
All iOS e2e tests pass.
## Test Plan
Reproduce the flow from the attached videos, it should be fine now.
## Screenshots / Videos
Before:
When changing the selection programmatically, via arrow keys, the typing
attributes are correctly preserved
https://github.com/user-attachments/assets/12cba319-1dd9-4cf0-8d05-8aa5b96228a7
When using screen taps though, the typing attributes are not preserved
resulting in the unstyled text, even though (in this case bold) was
marked as active
https://github.com/user-attachments/assets/3cbb75e0-0f0d-4c85-82bc-94424899979f
After:
Typing attributes are correctly preserved whatever the selection change
method
https://github.com/user-attachments/assets/7f18e399-10ac-4910-9b50-ab2f70f2e912
## Compatibility
| OS | Implemented |
| ------- | :---------: |
| iOS | ✅ |
| Android | ❌ |
| Web | ❌ |
## Checklist
- [ ] E2E tests are passing
- [ ] Required E2E tests have been added (if applicable)
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>1 parent bbe2db4 commit 08eed0e
6 files changed
Lines changed: 50 additions & 0 deletions
File tree
- .maestro/enrichedInput
- flows
- screenshots
- android
- ios
- ios
- inputAttributesManager
Lines changed: 34 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2000 | 2000 | | |
2001 | 2001 | | |
2002 | 2002 | | |
| 2003 | + | |
| 2004 | + | |
| 2005 | + | |
| 2006 | + | |
| 2007 | + | |
| 2008 | + | |
| 2009 | + | |
| 2010 | + | |
2003 | 2011 | | |
2004 | 2012 | | |
2005 | 2013 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| 22 | + | |
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| |||
129 | 131 | | |
130 | 132 | | |
131 | 133 | | |
| 134 | + | |
132 | 135 | | |
133 | 136 | | |
134 | 137 | | |
| |||
219 | 222 | | |
220 | 223 | | |
221 | 224 | | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
222 | 229 | | |
0 commit comments