Commit 21442fd
authored
fix: scrolling when height is not provided - android (#342)
# Summary
Fixes scrolling behavior when height/maxHeight is not provided for
android `EnrichedTextInput`. Before such component was not scrollable,
currently it scrolls properly (when not nested inside any other
scrollable component).
## Test Plan
- Define `EnrichedTextInput` outside of scrollable
- Specify basic styles for `EnrichedTextInput`. Ensure height and max
height are not provided
- Type long content, so component takes more space than screen height
- Notice that `EnrichedTextInput` is scrollable
## Screenshots / Videos
https://github.com/user-attachments/assets/4d0f3fe4-7e96-494d-a5c0-365bb4da425a
## Compatibility
| OS | Implemented |
| ------- | :---------: |
| iOS | ❌ |
| Android | ✅ |1 parent 728cd2f commit 21442fd
2 files changed
Lines changed: 22 additions & 2 deletions
File tree
- android/src/main/java/com/swmansion/enriched
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
365 | 365 | | |
366 | 366 | | |
367 | 367 | | |
368 | | - | |
| 368 | + | |
369 | 369 | | |
370 | 370 | | |
371 | 371 | | |
| |||
Lines changed: 21 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
157 | 158 | | |
158 | 159 | | |
159 | 160 | | |
160 | | - | |
| 161 | + | |
161 | 162 | | |
162 | 163 | | |
163 | 164 | | |
| |||
184 | 185 | | |
185 | 186 | | |
186 | 187 | | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
187 | 207 | | |
0 commit comments