Commit 7fa3793
authored
fix(ios): synced newline typing attributes with actual textStorage attributes (#775)
# Summary
Managing typing attributes was implemented in such way that when you
moved the cursor to an empty line, the typing attributes got reset. This
was to prevent picking up the style from the previous line, but it was
done unconditionally. That caused the typingAttributes to be reset even
though a style is already present in the newline and valid.
## Test Plan
Experiment around, follow the test flow from the attached videos
## Screenshots / Videos
Before:
https://github.com/user-attachments/assets/e0670f31-abf8-4953-b9e9-c97f7f50c1ef
After:
https://github.com/user-attachments/assets/2f9df226-4f90-451e-a611-4b501df50697
## Compatibility
| OS | Implemented |
| ------- | :---------: |
| iOS | ✅ |
| Android | ❌ |
| Web | ❌ |
## Checklist
- [ ] E2E tests are passing
- [ ] Required E2E tests have been added (if applicable)1 parent 08eed0e commit 7fa3793
1 file changed
Lines changed: 30 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
133 | 149 | | |
134 | 150 | | |
135 | 151 | | |
| |||
155 | 171 | | |
156 | 172 | | |
157 | 173 | | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
158 | 184 | | |
159 | 185 | | |
160 | 186 | | |
| |||
191 | 217 | | |
192 | 218 | | |
193 | 219 | | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
211 | 224 | | |
212 | 225 | | |
213 | 226 | | |
| |||
0 commit comments