chore: cleanup android hardcoded characters (#372)

# Summary

Replaces hardcoded characters with `EnrichedConstants`

Author: exploIF

android/src/main/java/com/swmansion/enriched/EnrichedTextInputView.kt

@@ -45,6 +45,7 @@ import com.swmansion.enriched.styles.InlineStyles
 import com.swmansion.enriched.styles.ListStyles
 import com.swmansion.enriched.styles.ParagraphStyles
 import com.swmansion.enriched.styles.ParametrizedStyles
+import com.swmansion.enriched.utils.EnrichedConstants
 import com.swmansion.enriched.utils.EnrichedEditableFactory
 import com.swmansion.enriched.utils.EnrichedParser
 import com.swmansion.enriched.utils.EnrichedSelection
@@ -335,7 +336,7 @@ class EnrichedTextInputView : AppCompatEditText {
       }
 
       // If the current char is not a hidden space, it counts towards our visible index
-      if (currentText[actualIndex] != '\u200B') {
+      if (currentText[actualIndex] != EnrichedConstants.ZWS) {
         currentVisibleCount++
       }
       actualIndex++

android/src/main/java/com/swmansion/enriched/events/OnChangeTextEvent.kt

@@ -4,6 +4,7 @@ import android.text.Editable
 import com.facebook.react.bridge.Arguments
 import com.facebook.react.bridge.WritableMap
 import com.facebook.react.uimanager.events.Event
+import com.swmansion.enriched.utils.EnrichedConstants
 
 class OnChangeTextEvent(
   surfaceId: Int,
@@ -16,7 +17,7 @@ class OnChangeTextEvent(
   override fun getEventData(): WritableMap {
     val eventData: WritableMap = Arguments.createMap()
     val text = editable.toString()
-    val normalizedText = text.replace(Regex("\\u200B"), "")
+    val normalizedText = text.replace(Regex(EnrichedConstants.ZWS_STRING), "")
     eventData.putString("value", normalizedText)
     return eventData
   }

android/src/main/java/com/swmansion/enriched/styles/ListStyles.kt

@@ -8,6 +8,7 @@ import com.swmansion.enriched.EnrichedTextInputView
 import com.swmansion.enriched.spans.EnrichedOrderedListSpan
 import com.swmansion.enriched.spans.EnrichedSpans
 import com.swmansion.enriched.spans.EnrichedUnorderedListSpan
+import com.swmansion.enriched.utils.EnrichedConstants
 import com.swmansion.enriched.utils.getParagraphBounds
 import com.swmansion.enriched.utils.getSafeSpanBoundaries
 import com.swmansion.enriched.utils.removeZWS
@@ -119,7 +120,7 @@ class ListStyles(
     }
 
     if (start == end) {
-      spannable.insert(start, "\u200B")
+      spannable.insert(start, EnrichedConstants.ZWS_STRING)
       view.spanState?.setStart(name, start + 1)
       removeSpansForRange(spannable, start, end, config.clazz)
       setSpan(spannable, name, start, end + 1)
@@ -132,7 +133,7 @@ class ListStyles(
     removeSpansForRange(spannable, start, end, config.clazz)
 
     for (paragraph in paragraphs) {
-      spannable.insert(currentStart, "\u200B")
+      spannable.insert(currentStart, EnrichedConstants.ZWS_STRING)
       val currentEnd = currentStart + paragraph.length + 1
       setSpan(spannable, name, currentStart, currentEnd)
 
@@ -164,15 +165,15 @@ class ListStyles(
     }
 
     if (!isBackspace && isShortcut) {
-      s.replace(start, cursorPosition, "\u200B")
+      s.replace(start, cursorPosition, EnrichedConstants.ZWS_STRING)
       setSpan(s, name, start, start + 1)
       // Inform that new span has been added
       view.selection?.validateStyles()
       return
     }
 
     if (!isBackspace && isNewLine && isPreviousParagraphList(s, start, config.clazz)) {
-      s.insert(cursorPosition, "\u200B")
+      s.insert(cursorPosition, EnrichedConstants.ZWS_STRING)
       setSpan(s, name, start, end + 1)
       // Inform that new span has been added
       view.selection?.validateStyles()

android/src/main/java/com/swmansion/enriched/styles/ParagraphStyles.kt

@@ -7,6 +7,7 @@ import android.util.Log
 import com.swmansion.enriched.EnrichedTextInputView
 import com.swmansion.enriched.spans.EnrichedSpans
 import com.swmansion.enriched.spans.interfaces.EnrichedSpan
+import com.swmansion.enriched.utils.EnrichedConstants
 import com.swmansion.enriched.utils.getParagraphBounds
 import com.swmansion.enriched.utils.getSafeSpanBoundaries
 import com.swmansion.enriched.utils.removeZWS
@@ -344,7 +345,7 @@ class ParagraphStyles(
           endCursorPosition -= 1
           spanState.setStart(style, null)
         } else {
-          s.insert(endCursorPosition, "\u200B")
+          s.insert(endCursorPosition, EnrichedConstants.ZWS_STRING)
           endCursorPosition += 1
         }
       }
@@ -393,7 +394,7 @@ class ParagraphStyles(
     }
 
     if (start == end) {
-      spannable.insert(start, "\u200B")
+      spannable.insert(start, EnrichedConstants.ZWS_STRING)
       setAndMergeSpans(spannable, type, start, end + 1)
       view.selection.validateStyles()
 
@@ -405,7 +406,7 @@ class ParagraphStyles(
     val paragraphs = spannable.substring(start, end).split("\n")
 
     for (paragraph in paragraphs) {
-      spannable.insert(currentStart, "\u200B")
+      spannable.insert(currentStart, EnrichedConstants.ZWS_STRING)
       currentEnd = currentStart + paragraph.length + 1
       currentStart = currentEnd + 1
     }

android/src/main/java/com/swmansion/enriched/styles/ParametrizedStyles.kt

@@ -9,6 +9,7 @@ import com.swmansion.enriched.spans.EnrichedImageSpan
 import com.swmansion.enriched.spans.EnrichedLinkSpan
 import com.swmansion.enriched.spans.EnrichedMentionSpan
 import com.swmansion.enriched.spans.EnrichedSpans
+import com.swmansion.enriched.utils.EnrichedConstants
 import com.swmansion.enriched.utils.getSafeSpanBoundaries
 import com.swmansion.enriched.utils.removeZWS
 
@@ -263,14 +264,14 @@ class ParametrizedStyles(
     val (start, originalEnd) = view.selection.getInlineSelection()
 
     if (start == originalEnd) {
-      spannable.insert(start, "\uFFFC")
+      spannable.insert(start, EnrichedConstants.ORC_STRING)
     } else {
       val spans = spannable.getSpans(start, originalEnd, EnrichedImageSpan::class.java)
       for (s in spans) {
         spannable.removeSpan(s)
       }
 
-      spannable.replace(start, originalEnd, "\uFFFC")
+      spannable.replace(start, originalEnd, EnrichedConstants.ORC_STRING)
     }
 
     val (imageStart, imageEnd) = spannable.getSafeSpanBoundaries(start, start + 1)

android/src/main/java/com/swmansion/enriched/utils/EnrichedConstants.kt

@@ -0,0 +1,11 @@
+package com.swmansion.enriched.utils
+
+object EnrichedConstants {
+  // Zero Width Space
+  const val ZWS = '\u200B'
+  const val ZWS_STRING = "\u200B"
+
+  // Object Replacement Character
+  const val ORC = '\uFFFC'
+  const val ORC_STRING = "\uFFFC"
+}

android/src/main/java/com/swmansion/enriched/utils/EnrichedParser.java

@@ -337,7 +337,7 @@ private static void withinParagraph(StringBuilder out, Spanned text, int start,
   private static void withinStyle(StringBuilder out, CharSequence text, int start, int end) {
     for (int i = start; i < end; i++) {
       char c = text.charAt(i);
-      if (c == '\u200B') {
+      if (c == EnrichedConstants.ZWS) {
         // Do not output zero-width space characters.
         continue;
       } else if (c == '<') {
@@ -431,9 +431,9 @@ public Spanned convert() {
       int start = mSpannableStringBuilder.getSpanStart(zeroWidthSpaceSpan);
       int end = mSpannableStringBuilder.getSpanEnd(zeroWidthSpaceSpan);
 
-      if (mSpannableStringBuilder.charAt(start) != '\u200B') {
+      if (mSpannableStringBuilder.charAt(start) != EnrichedConstants.ZWS) {
         // Insert zero-width space character at the start if it's not already present.
-        mSpannableStringBuilder.insert(start, "\u200B");
+        mSpannableStringBuilder.insert(start, EnrichedConstants.ZWS_STRING);
         end++; // Adjust end position due to insertion.
       }
 
@@ -717,7 +717,7 @@ private static void setParagraphSpanFromMark(Editable text, Object mark, Object.
 
     // Block spans require at least one character to be applied.
     if (isEmptyTag) {
-      text.append("\u200B");
+      text.append(EnrichedConstants.ZWS);
       len++;
     }
 

android/src/main/java/com/swmansion/enriched/utils/EnrichedSelection.kt

@@ -64,13 +64,13 @@ class EnrichedSelection(
     val text = view.text ?: return false
 
     if (start != end) {
-      return text.substring(start, end) == "\u200B"
+      return text.substring(start, end) == EnrichedConstants.ZWS_STRING
     }
 
     val isNewLine = if (start > 0) text.substring(start - 1, start) == "\n" else true
     val isNextCharacterZeroWidth =
       if (start < text.length) {
-        text.substring(start, start + 1) == "\u200B"
+        text.substring(start, start + 1) == EnrichedConstants.ZWS_STRING
       } else {
         false
       }

android/src/main/java/com/swmansion/enriched/utils/Utils.kt

@@ -106,7 +106,7 @@ fun SpannableStringBuilder.removeZWS(
   end: Int,
 ) {
   for (i in (end - 1) downTo start) {
-    if (this[i] == '\u200B') {
+    if (this[i] == EnrichedConstants.ZWS) {
       delete(i, i + 1)
     }
   }