Skip to content

Commit acc0fe2

Browse files
authored
chore: upgrade min maestro version (#482)
# Summary Maestro [2.3.0](https://github.com/mobile-dev-inc/maestro/blob/main/CHANGELOG.md#230) added a fix to `assertScreenshot` that makes the assertion fail when the current screenshot and baseline image have different dimensions. From now on we will require for Maestro to be at least version 2.3.0. ## Test Plan + Try to run tests with Maestro v2.2.0 + Upgrade Maestro to v2.3.0 + See if tests pass ## Screenshots / Videos N/A ## Compatibility | OS | Implemented | | ------- | :---------: | | iOS | ✅ | | Android | ✅ |
1 parent e702245 commit acc0fe2

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.maestro/scripts/run-tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
set -euo pipefail
2121

22-
MIN_MAESTRO_VERSION="2.2.0"
22+
MIN_MAESTRO_VERSION="2.3.0"
2323

2424
if ! command -v maestro >/dev/null 2>&1; then
2525
echo "Error: maestro CLI not found." >&2

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ We use [Maestro](https://maestro.mobile.dev/) for end-to-end testing. Flows live
8080

8181
#### Prerequisites
8282

83-
- **Maestro CLI** (v2.2.0+) - follow the [Getting Started guide](https://github.com/mobile-dev-inc/maestro?tab=readme-ov-file#getting-started). After installing, ensure `~/.maestro/bin` is in your `PATH`.
83+
- **Maestro CLI** (v2.3.0+) - follow the [Getting Started guide](https://github.com/mobile-dev-inc/maestro?tab=readme-ov-file#getting-started). After installing, ensure `~/.maestro/bin` is in your `PATH`.
8484
- **iOS** - Xcode. Ensure `xcrun` is available (it ships with Xcode Command Line Tools).
8585
- **Android** - Android SDK with SDK Command-line Tools, SDK Platform-Tools, Emulator. Set up `ANDROID_HOME` (typically `$HOME/Library/Android/sdk` on macOS) and ensure the following are in your `PATH`:
8686
- `$ANDROID_HOME/cmdline-tools/latest/bin`

0 commit comments

Comments
 (0)