Skip to content

Commit ec1c03f

Browse files
authored
fix(web): headings font color inheritance (#710)
# Summary The color of the headings - `h1`, `h2`, ..., was not properly defined. You could create a CSS rule e.g `h1 { color: 'white' }` in an app's higher context and that color would get applied, it did not use the editor's `color`. Now it properly inherits it. ## Compatibility | OS | Implemented | | ------- | :---------: | | iOS | ❌ | | Android | ❌ | | Web | ✅ | ## Checklist - [x] E2E tests are passing - [ ] Required E2E tests have been added (if applicable)
1 parent af40bf0 commit ec1c03f

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

src/web/EnrichedText.css

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,41 +47,47 @@
4747
font-weight: var(--et-h1-font-weight);
4848
margin: 0;
4949
line-height: normal;
50+
color: inherit;
5051
}
5152
.eti-editor h2,
5253
.et-view h2 {
5354
font-size: var(--et-h2-font-size);
5455
font-weight: var(--et-h2-font-weight);
5556
margin: 0;
5657
line-height: normal;
58+
color: inherit;
5759
}
5860
.eti-editor h3,
5961
.et-view h3 {
6062
font-size: var(--et-h3-font-size);
6163
font-weight: var(--et-h3-font-weight);
6264
margin: 0;
6365
line-height: normal;
66+
color: inherit;
6467
}
6568
.eti-editor h4,
6669
.et-view h4 {
6770
font-size: var(--et-h4-font-size);
6871
font-weight: var(--et-h4-font-weight);
6972
margin: 0;
7073
line-height: normal;
74+
color: inherit;
7175
}
7276
.eti-editor h5,
7377
.et-view h5 {
7478
font-size: var(--et-h5-font-size);
7579
font-weight: var(--et-h5-font-weight);
7680
margin: 0;
7781
line-height: normal;
82+
color: inherit;
7883
}
7984
.eti-editor h6,
8085
.et-view h6 {
8186
font-size: var(--et-h6-font-size);
8287
font-weight: var(--et-h6-font-weight);
8388
margin: 0;
8489
line-height: normal;
90+
color: inherit;
8591
}
8692

8793
.eti-editor blockquote,

0 commit comments

Comments
 (0)