iOS headings improvements - #177
Merged
Merged
Conversation
szydlovsky
commented
Oct 1, 2025
szydlovsky
commented
Collaborator
- added a check that makes sure headings attributes are removed after entering
- added a check that fixes attributes of text artificially incorporated into headings (by backspacing it from a following line)
- remade the logic of the checks made before the text change is committed. Previous approach could result in crashes because checks that actually changed something influenced the following checks. Since no two of them can go off at the same time, now they are mutually exclusive - if one goes off, others don't
exploIF
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.