feat: android - measurement improvements - #221
Merged
Merged
Conversation
…urement-improvements
…urement-improvements # Conflicts: # android/src/main/java/com/swmansion/enriched/EnrichedTextInputViewLayoutManager.kt
…urement-improvements
exploIF
marked this pull request as ready for review
October 31, 2025 12:08
szydlovsky
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to provide auto-grow mechanism on Android we use
StaticLayoutwhich calculates desired component height based on the text paint, spannable and available width.Current logic comes with a huge limitation, it does work properly only for single instance of the component (as we store last created component instance directly in the view manager).
In order to solve this limitation, I've implemented an enhanced version of this mechanism:
idwhich equals toviewTagmeasureContentandmeasureon the view manager) we retrieve a measurement value from the static class store (calledMeasurementStore)