Skip to content

feat: add clang-format - #232

Merged
exploIF merged 2 commits into
software-mansion:mainfrom
IvanIhnatsiuk:feat/clang-format
Dec 10, 2025
Merged

exploIF merged 2 commits into
software-mansion:mainfrom
IvanIhnatsiuk:feat/clang-format

Conversation

@IvanIhnatsiuk

Copy link
Copy Markdown
Contributor

Description

Added clang-format to format C++ and Objective-C code

How to test?

Run yarn lint-clang command

@exploIF

exploIF commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator

Thank you for this. Ideally we would like to merge such PRs in two steps:

  • PR with formatting setup and disabled CI check
  • PR with actual formatting applied created by one of the maintainers

Currently it's pretty hard to review it, as there are so many changes in single commit. Hard to see if there are only formatting related changes

@kacperzolkiewski kacperzolkiewski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀
It formats code properly.

Comment thread .github/workflows/lint-clang.yaml Outdated
Co-authored-by: Tomasz Zawadzki <tomekzawadzki98@gmail.com>

@exploIF exploIF left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor comment and we can merge it

Comment thread .github/workflows/lint-clang.yaml
@exploIF
exploIF self-requested a review December 9, 2025 08:09
@exploIF
exploIF merged commit c7a7a2a into software-mansion:main Dec 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants