Conversation
|
@IvanIhnatsiuk thanks for this, as this PR can have some impact on apps which are already using library, I would like to discuss this a little bit more. It would be super cool if you can catch up with me on discord (username |
exploIF
left a comment
exploIF
left a comment
There was a problem hiding this comment.
Have you tested how it works when htmlStyle is defined inside render? Even if it's memoized it can be re-rendered. I'm afraid it may not work properly in such scenario, because of pretty simple detection if html style has been updated
6762946 to
f6f54e4
Compare
exploIF
left a comment
exploIF
left a comment
There was a problem hiding this comment.
I really like this approach, we just need couple minor adjustments
|
Hi @IvanIhnatsiuk, Screen.Recording.2025-12-12.at.10.43.12.mov |
|
@kacperzolkiewski I don't think it disappears, it looks like the layout is not updated 🤔 |
f6f54e4 to
04510f3
Compare
|
@kacperzolkiewski could you check on the latest branch version? |
|
@IvanIhnatsiuk unfortunately still the same, it looks like it is not scrolling to the top: Screen.Recording.2025-12-12.at.13.42.12.mov |
04510f3 to
c31c37b
Compare
could you retest on the latest branch version? |
|
Works fine now 👏 |
exploIF
left a comment
exploIF
left a comment
There was a problem hiding this comment.
Looks good to me. I've pushed couple tiny changes (mostly code style related)
3 participants
Description
If we change the HTML styles on Android, they will not be applied in any way until we first enter any styles. We also got a bug with the initial defaultValue, because everything started to depend on who was the first to be counted (it depends on who was the first to be passed from JS to the component).
Thus, I added the calculation of the lead when changing the HTML style on Android.
Videos
Before:
Screen.Recording.2025-11-07.at.19.24.38.mov
Screen.Recording.2025-11-07.at.19.16.29.mov
After:
Screen.Recording.2025-11-07.at.19.25.20.mov