Skip to content

fix: handle style conflicts during automatic links detection #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
exploIF merged 6 commits into from
Nov 18, 2025
Merged

fix: handle style conflicts during automatic links detection #257

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aee9b96
fix: handle style conflicts during automatic links detection
kacperzolkiewski Nov 17, 2025
8abc4b0
fix: use spanState variable
kacperzolkiewski Nov 17, 2025
cbd86cc
fix: remove newline
kacperzolkiewski Nov 17, 2025
233ed80
Merge branch 'main' into fix-automatic-links-conflicts
kacperzolkiewski Nov 17, 2025
bb4d93e
fix: getting merging config
kacperzolkiewski Nov 17, 2025
e7a5039
fix: rename detectLinkConflicts function
kacperzolkiewski Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions android/src/main/java/com/swmansion/enriched/styles/ParametrizedStyles.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,31 @@ class ParametrizedStyles(private val view: EnrichedTextInputView) {
return Triple(result, start, end)
}

private fun canLinkBeApplied(): Boolean {
val mergingConfig = EnrichedSpans.getMergingConfigForStyle(EnrichedSpans.LINK, view.htmlStyle)?: return true
val conflictingStyles = mergingConfig.conflictingStyles
val blockingStyles = mergingConfig.blockingStyles

for (style in blockingStyles) {
if (view.spanState?.getStart(style) != null) return false
}

for (style in conflictingStyles) {
if (view.spanState?.getStart(style) != null) return false
}

return true
}

private fun afterTextChangedLinks(result: Triple<String, Int, Int>) {
// Do not detect link if it's applied manually
if (isSettingLinkSpan) return
if (isSettingLinkSpan || !canLinkBeApplied()) return

val spannable = view.text as Spannable
val (word, start, end) = result

// TODO: Consider using more reliable regex, this one matches almost anything
val urlPattern = android.util.Patterns.WEB_URL.matcher(word)

val spans = spannable.getSpans(start, end, EnrichedLinkSpan::class.java)
for (span in spans) {
spannable.removeSpan(span)
Expand Down
Loading