feat: make <a> tags with no href or empty href not treated as links - #260
Merged
Merged
Conversation
kacperzolkiewski
approved these changes
Nov 19, 2025
exploIF
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is an alternative to other PR in here handling iOS crashes due to
<a>tag not havinghrefattribute. While the other on e decides to allow emptyhrefsas proper links, Android has no such logic. We discussed it a bit with @exploIF and are more eager to go the following way;hrefattribute or an empty one =><a>tag not treated as a a linkTest Plan
Set input's valuefield or into the component'sdefaultValueprop inApp.tsx;Should be nicely treated as a link. Now make the href empty or completely remove the attribute from the tag. It should not be treated as a link and a new html won't have an
<a>tag in there anymore.Screenshots / Videos
--
Compatibility