Skip to content

feat: make <a> tags with no href or empty href not treated as links - #260

Merged
szydlovsky merged 2 commits into
mainfrom
@szydlovsky/no-href-crash-ios
Nov 20, 2025
Merged

szydlovsky merged 2 commits into
mainfrom
@szydlovsky/no-href-crash-ios

Conversation

@szydlovsky

@szydlovsky szydlovsky commented Nov 18, 2025

Copy link
Copy Markdown
Collaborator

Summary

This PR is an alternative to other PR in here handling iOS crashes due to <a> tag not having href attribute. While the other on e decides to allow empty hrefs as proper links, Android has no such logic. We discussed it a bit with @exploIF and are more eager to go the following way;

  • No href attribute or an empty one => <a> tag not treated as a a link

Test Plan

  • Open iOS example app
  • Input following html either into Set input's value field or into the component's defaultValue prop in App.tsx;
<html>
<p><a href="xd.com">Test2xdd</a></p>
</html>

Should be nicely treated as a link. Now make the href empty or completely remove the attribute from the tag. It should not be treated as a link and a new html won't have an <a> tag in there anymore.

Screenshots / Videos

--

Compatibility

OS Implemented
iOS
Android ✅ (already handled that way)

Comment thread ios/inputParser/InputParser.mm
@szydlovsky
szydlovsky merged commit 4a51e61 into main Nov 20, 2025
5 checks passed
@szydlovsky
szydlovsky deleted the @szydlovsky/no-href-crash-ios branch November 20, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants