Skip to content

feat: make <a> tags with no href or empty href not treated as links #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szydlovsky merged 2 commits into from
Nov 20, 2025
Merged

feat: make <a> tags with no href or empty href not treated as links #260

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdd1876
feat: make <a> tags with no href or empty href not treated as links
szydlovsky Nov 18, 2025
7229c3a
fix: bring back a comment
szydlovsky Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ios/inputParser/InputParser.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,9 +610,21 @@ - (NSArray *)getTextAndStylesFromHtml:(NSString *)fixedHtml {
} else if([tagName isEqualToString:@"code"]) {
[styleArr addObject:@([InlineCodeStyle getStyleType])];
} else if([tagName isEqualToString:@"a"]) {
NSRegularExpression *hrefRegex = [NSRegularExpression regularExpressionWithPattern:@"href=\".+\""
options:0
error:nullptr
];
NSTextCheckingResult* match = [hrefRegex firstMatchInString:params options:0 range: NSMakeRange(0, params.length)];

if(match == nullptr) {
// same as on Android, no href (or empty href) equals no link style
continue;
}

NSRange hrefRange = match.range;
[styleArr addObject:@([LinkStyle getStyleType])];
// cut only the url from the href="..." string
NSString *url = [params substringWithRange:NSMakeRange(6, params.length - 7)];
NSString *url = [params substringWithRange:NSMakeRange(hrefRange.location + 6, hrefRange.length - 7)];
Comment thread
szydlovsky marked this conversation as resolved.
stylePair.styleValue = url;
} else if([tagName isEqualToString:@"mention"]) {
[styleArr addObject:@([MentionStyle getStyleType])];
Expand Down Expand Up @@ -657,7 +669,7 @@ - (NSArray *)getTextAndStylesFromHtml:(NSString *)fixedHtml {
} else if([tagName isEqualToString:@"blockquote"]) {
[styleArr addObject:@([BlockQuoteStyle getStyleType])];
} else {
// some other external tags like span just don't get put into the processed styles
// some other external tags like span just don't get put into the processed styles
continue;
}

Expand Down
Loading